Skip to content

draft1 of nisar and biomass#84

Open
HarshiniGirish wants to merge 1 commit intoMAAP-Project:mainfrom
HarshiniGirish:nisar_biomass_gedi
Open

draft1 of nisar and biomass#84
HarshiniGirish wants to merge 1 commit intoMAAP-Project:mainfrom
HarshiniGirish:nisar_biomass_gedi

Conversation

@HarshiniGirish
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,1002 @@
{
Copy link
Collaborator

@wildintellect wildintellect Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more interesting to show the polygons on a map.


Reply via ReviewNB

@@ -0,0 +1,1002 @@
{
Copy link
Collaborator

@wildintellect wildintellect Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the colors for each layer


Reply via ReviewNB

@@ -0,0 +1,1002 @@
{
Copy link
Collaborator

@wildintellect wildintellect Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #12.        folium.GeoJson(nisar_gdf.__geo_interface__, name="NISAR").add_to(m)

@chuckwondo mentioned you can drop the geo_interface accessor

folium.GeoJson(nisar_gdf, name="NISAR").add_to(m)


Reply via ReviewNB

@@ -0,0 +1,1002 @@
{
Copy link
Collaborator

@wildintellect wildintellect Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to do this section at all. We'll be relying on GEDI subsetter or Amelia's new GEDI tiler to extract points for a given location.

In it's place just do the same STAC search as the other data, and show the bounding boxes on the map.


Reply via ReviewNB

@@ -0,0 +1,1002 @@
{
Copy link
Collaborator

@wildintellect wildintellect Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we did keep this, you should use a spatial format gpkg, or geoparquet to store the results, not a CSV.


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants