Remove Basic auth from EDC credentials header#236
Open
sujen1412 wants to merge 3 commits into
Open
Conversation
bsatoriu
previously approved these changes
May 27, 2026
Collaborator
bsatoriu
left a comment
bsatoriu
left a comment
There was a problem hiding this comment.
I verified this works for a valid EDL token. DAACs tested:
The combined 'Bearer {token},Basic {creds}' Authorization header caused
the LP DAAC S3 credentials endpoint to reject the request and redirect
to the EDL OAuth login page instead of returning credentials, resulting
in a JSONDecodeError when the empty/HTML response was parsed.
https://claude.ai/code/session_017YKqMqZHprcFmzXrt1p9HX
Remove edl_federated_request from s3 credentials flow and add error handling.
bsatoriu
force-pushed
the
fix/148-edc-credentials-auth-header
branch
from
ce5a63f to
cd8f655
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Basic authentication credentials from the EDC (Earthdata Data Cloud) authorization header in the members endpoint. The header now only includes the Bearer token for URS authentication.
Changes
get_edc_credentials()function to removeBasic {settings.MAAP_EDL_CREDS}from the Authorization header, keeping only the Bearer token authenticationDetails
The Authorization header in the EDC credentials request previously included both Bearer token and Basic authentication. This change simplifies the authentication to use only the Bearer token, which is the standard approach for URS (User Registration System) authentication with Earthdata Login.
Fixes #148