Open
Conversation
Using http://goo.gl/6AQ3u might fail. The resulting backup consists of a tarball of the filesystem being backed up, but it might end up truncated, for reasons yet unknown. Issuing adb backup data, for instance, causes recovery to call tar, streaming it's stdout <a> through a socket <b>. The adb client reads from <b> and copies what it to the final backup file. Somehow, sometimes, not all the content generated at <a> is read at the adb client, which causes a truncated tar file to result. I'm unsure why this happens: Doesn't <a> get flushed before <b> is closed? Or is it that <b> is closed with outstanding data in its buffers, which never make it to the other side? Either calling sync() or sleep() seems to remedy the issue, but I'm not sure if sync() has any effect on sockets or pipes. I also understand that sleeping for some time is not the best solution to a race condition. Therefore, I'm adding calls to sync() and sleep() and waiting for reviews from someone who knows better how these calls work. Patch set 2: Remove sync() call Change-Id: If4733066fdad809eb73e87c670f37acc4debe82d
When /sdcard is /data/media, it can be formatted but it cannot be mounted/unmounted independently of /data (aside from creating or destrying the symlink). This removes /sdcard from the mountable volumes list, but leaves it as a formattable partition. Change-Id: If59e4516a12da4589ffb0dbd19702f219260370e
ITEM_APPLY_SDCARD is already defined in recovery_ui.h, fortunately also as 1. This suggestion comes from Phil3759. Change-Id: I9ac370ca9640d61b6b96f60954d35f7aa458d75b
Signed-off-by: Chirayu Desai <cdesai@cyanogenmod.org> Change-Id: I9849c69777d513bb12926c8c622d1c12d2da568a
* Also includes the below commit: fix installation from internal sdcard bug introduced in previous commit Change-Id: If41d409801e9a58df9515ac783bf503f80909d3e * I've done some minor changes to the original commit, which includes but is not limited to moving the "install zip from sideload" above "/sdcard/update.zip". Signed-off-by: Chirayu Desai <cdesai@cyanogenmod.org> Change-Id: I27a763a0d41085719a6c7d9c3b8a20fbcae4b072
Extral newline can trigger recovery segmentation fault Test case: host$ adb shell 'echo -en "--update_package=ota_update.zip\n--show_text\n\n" > /cache/recovery/command' host$ adb reboot recovery Change-Id: If1781c1f5ad94a273f1cb122b67cedd9fb562433 Signed-off-by: Jin Feng <jin88.feng@gmail.com>
When resorting to using mount because a block device uses 'auto' filesystem, we should use the mount point and not the full path. This fixes an issue with nandroid to external sd on yuga. Change-Id: Idbff944ea6d5af9112644c2ed46e23ea0a33e5ee
Change-Id: Iab3290adca1602a23fc407d2b3f50b9aeac60389
Change-Id: Id59b79f079c587630f5f6ed0418a45f2b8cd99ff Conflicts: nandroid.c
Change-Id: I089fad25002a28cc5b368288c5bb34c37f9752bc
Depends on http://review.cyanogenmod.org/#/c/37912/ Change-Id: I7d541813f520c3a3187f6c193e47b201cd220957
Change-Id: I1456e7e2d2a1f3e143c084e1410dd31c505793ad
Change-Id: I6338ed1d093a8db20250bd060cf97896db268976
Change-Id: I25243f67b8bcbef41867497b442d1b7f38f638dd
Original discussion here: http://review.cyanogenmod.org/45559 Patchset 2: really remove the option Patchset 3: fix options that I broke on ps2 Signed-off-by: Michael Bestas <mikeioannina@gmail.com> Change-Id: I54877a24444c24a296c8c044efd977f30cc66de4
Also: Cleanup leftovers from previous poweroff option Always ensure a clean reboot (Thanks to PhilZ for his implementation) Bootloader option defaults to "bootloader" (fastboot mode), it can be overriden by defining "ro.bootloader.mode=download" prop for samsung download mode We leave reboot to bootloader option always enabled, that way we can override the get_filtered_menu_selection bug that breaks the order of the options when NULLifying menu options. Signed-off-by: Michael Bestas <mikeioannina@gmail.com> Change-Id: I6d674b37ab41ab342b105993719277360b4707e4
Change-Id: Ic5716e5f2c311406bc6384e63fb0f217113e6eeb
the releasetools want this now Change-Id: Ibc3cdbc8f5f8022bf51479a4702d1d0d043f70a9
v1 is the old recovery.fstab format that everybody is still using. Devices using v2 should set RECOVERY_FSTAB_VERSION=2 in their board files Change-Id: Ie7221f110ecc594f6f92973d2c27da10f62b6431
Original discussion here: http://review.cyanogenmod.org/45559 Patchset 2: really remove the option Patchset 3: fix options that I broke on ps2 Signed-off-by: Michael Bestas <mikeioannina@gmail.com> Change-Id: I54877a24444c24a296c8c044efd977f30cc66de4
Also: Cleanup leftovers from previous poweroff option Always ensure a clean reboot (Thanks to PhilZ for his implementation) Bootloader option defaults to "bootloader" (fastboot mode), it can be overriden by defining "ro.bootloader.mode=download" prop for samsung download mode We leave reboot to bootloader option always enabled, that way we can override the get_filtered_menu_selection bug that breaks the order of the options when NULLifying menu options. Signed-off-by: Michael Bestas <mikeioannina@gmail.com> Change-Id: I6d674b37ab41ab342b105993719277360b4707e4
Change-Id: I86a280088ee8767e02ba51b72f4d011cf4658f6f
Change-Id: I86a280088ee8767e02ba51b72f4d011cf4658f6f
Change-Id: Idce9a6d4ca18ddc9b49029024c26bc114f6d3c15
Change-Id: I5bbd6bd7239680f20880ac6fdf7744e2e47b39ac
all the extra no options. Change-Id: I1362815b18f4f1aeecb7426689f38bf8f1f1f008
Enabled via BOARD_RECOVERY_SWIPE := true in BoardConfig.mk.
Does not interfere with hardware keys, they continue to work.
Patchset 1) Initial set
Patchset 2) change Board Config variable
don't add if BOARD_TOUCH_RECOVERY set
Patchset 3) more ifdef's for all!
Patchset 4) moved instructions
even more stuff ifdef'ed
no more abs name issues
Patchset 5) clean up commit message
Patchset 6) Move things to swipe.c to clean up ui.c
Patchset 7) white space
Change-Id: Id9844c38c31bd1985dd78a6d1dd81e71aa1f87f3
Change-Id: I576c054dc5ab6a080e499f26c8cb2a66ecb8ae42
- do not show partition sdcard entries for vold managed volumes until we have a valid blk_device2. That also caused a memory overflow - make it possible again to partition old style blk_device volumes - enable format voldmanaged devices to ext2 and ext3 with existing binaries by using optional blk_device2 (defined in recovery to NULL but not currently implemented by fs_mgr - fix unexpected behavior when in format/partition menus and insert an usb key (REFRESH return code) - ensure_path_unmounted() could not unmount /sdcard path on /data/media devices - format_device() and format_volume() properly handle /sdcard path argument on /data/media devices Change-Id: I2d5872690805e70175ba1346fd03978e3c2b879e
This will preserve logging for format/usb mount and for all USB OTG storage Change-Id: I0ab41632b4b97d23a43471755e21d9750c6cfa04
Change-Id: I43ad3d2600b9529d726aac435f0091713786ac4f
Change-Id: Ie94b28694c12182652464c4b8e61ab4c67905b07
* AOSP added a "bold" flag for image based fonts. Stay compatible with that API since there are other components using minui. Change-Id: I6c0f12f7f8f1df8dd27779b47883ccff96f2d291
Change-Id: I6ec438f61cafce69c5083977c4330277f56aa060
* Breaks every device because of their deprecated graphics.c overloads. * Revert until we clean this mess up. This reverts commit 48ccdce.
Change-Id: I8179607517f55b2941924b5726e0e57b012f8e18
* Some devices rely on the LCD backlight to blank/unblank the display, support them by allowing a custom LCD backlight path to be used. Change-Id: I8406b4b55cd7a2afc4f8f8ba65de2c53b949489d
* Clean all the stuff that conflicts with AOSP recovery. Change-Id: I175329c446a014c451f4c0fc5a9a4472941afc10
* We need to clean everything, otherwise nasty things happen when switching to alternate recovery module. Change-Id: I9ea88179f5329112c587b649328c1c83df0bd5d9
This reverts commit 2457cc0.
Introduce two new updater functions:
* set_metadata
* set_metadata_recursive
Long term, these functions are intended to be more flexible replacements
for the following methods:
* set_perm
* set_perm_recursive
Usage:
set_metadata("filename", "key1", "value1", "key2", "value2", ...)
set_metadata_recursive("dirname", "key1", "value1", "key2", "value2", ...)
Description:
set_metadata() and set_metadata_recursive() set the attributes on a file/directory
according to the key/value pairs provided. Today, the following keys are
supported:
* uid
* gid
* mode (set_perm_extd only)
* fmode (set_perm_extd_recursive only)
* dmode (set_perm_extd_recursive only)
* selabel
* capabilities
Unknown keys are logged as warnings, but are not fatal errors.
Examples:
* set_metadata("/system/bin/netcfg", "selabel", "u:object_r:system_file:s0");
This sets the SELinux label of /system/bin/netcfg to u:object_r:system_file:s0.
No other changes occur.
* set_metadata("/system/bin/netcfg", "uid", 0, "gid", 3003, "mode", 02750, "selabel", "u:object_r:system_file:s0", "capabilities", 0x0);
This sets /system/bin/netcfg to uid=0, gid=3003, mode=02750,
selinux label=u:object_r:system_file:s0, and clears the capabilities
associated with the file.
* set_metadata_recursive("/system", "uid", 0, "gid", 0, "fmode", 0644, "dmode", 0755, "selabel", "u:object_r:system_file:s0", "capabilities", 0x0);
All files and directories under /system are set to uid=0, gid=0,
and selinux label=u:object_r:system_file:s0. Directories are set to
mode=0755. Files are set to mode=0644 and all capabilities are cleared.
Bug: 10183961
Bug: 10186213
Bug: 8985290
Change-Id: Ifdcf186a7ed45265511dc493c4036e1ac5e3d0af
Bug: 10183961 Bug: 10186213 Bug: 8985290 Change-Id: I57cb14af59682c5f25f1e091564548bdbf20f74e
Add a copy of reboot.c from system/core/reboot, since it is no longer a cleanly usable tool in toolbox. minor API updates
Change-Id: Ifd5a29d459acf101311fa1c220f728c3d0ac2e4e
Change-Id: I16e3e0ddb8ca062431deb4be83c5be5eb786d76f
Copy logs to /cache immediately upon a package installation failure; don't wait for recovery to finish. (If the user reboots without exiting recovery the "right" way, the logs never get copied at all.) Change-Id: Iee342944e7ded63da5a4af33d11ebc876f6c0835
When doing a cache wipe or a factory reset (which includes a cache wipe), save any last* log files in the /cache/recovery directory and write them back after reformatting the partition, so that wiping data doesn't lose useful log information. Change-Id: I1f52ae9131760b5e752e136645c19f71b7b166ee
Recovery's init.rc was missing a line (added to the main system's init.rc in change Ic97fd464440ff4a29fc9da7ad15949ac5215ade3) is required for secure adb to work. Change-Id: Id79b94d2abb4cbe3cca7cabeb4bc5faf7205e56b
…cm-11.0 bunch version to 6.0.4.4 Signed-off-by: sndnvaps <sndnvaps@gmail.com>
Signed-off-by: sndnvaps <sndnvaps@gmail.com>
Author
|
刚解决了extendedcommands.c的冲突了. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i just merge git@github.com:CyanogenMod/android_bootable_recovery.git
into a new branch
i hope you can merge it .
or open a new branch .