Support multiple adhoc-swapchains, use for multi-layered images#2835
Conversation
fabian-lunarg
added
the
approved-to-run-ci
fabian-lunarg
force-pushed
the
fabian_present_override_follow_up
branch
from
a93277d to
2f17fb0
Compare
| AdhocSwapChain(AdhocSwapChain&& other) noexcept : AdhocSwapChain() { swap(*this, other); } | ||
| AdhocSwapChain& operator=(AdhocSwapChain other) noexcept | ||
| { | ||
| swap(*this, other); |
There was a problem hiding this comment.
Do you need "using std::swap" above this too (and above on line 219) or at least globally?
There was a problem hiding this comment.
only used in the body of AdHocSwapChain::swap(), so should not have spilled into the namespace.
| title_ss << " - " << window_width << " x " << window_height; | ||
| if (layer_count > 1) | ||
| { | ||
| title_ss << " - layer: " << (layer + 1) << " / " << layer_count; |
There was a problem hiding this comment.
Is it typical for layers to be 1 based?
There was a problem hiding this comment.
no, but I thought it would make more intuitive sense, when displaying as a count. e.g. for two images I wanted to avoid: 0 / 2 | 1 / 2 and preferred 1 / 2 | 2 / 2. also the resulting title-bar is not guaranteed to be even visible (e.g. on wayland we do not render window-decorations at all). so this whole string-formatting was mostly a nice to have
|
thank you @MarkY-LunarG ! |
fabian-lunarg
force-pushed
the
fabian_present_override_follow_up
branch
from
2f17fb0 to
3f79f37
Compare
…rG#2835) * Fix for fallback-VkFormat, check if SRGB is required * refactor AdhocSwapChain lifecycle, allow multiple windows (WIP) * Support mutliple adhoc-swapchains, use for multi-layered images * window-title and positioning. report layer-idx, if any. tile to avoid overlap * missing header-include for android
2 participants
Swapchain::PresentImageAdHocusing multiple windows