Skip to content

Conversation

@mateeullahmalik
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors event type usage in SDK progress tracking and updates task status handling throughout the codebase. Key changes include:

  • Replacement of legacy event type names with new SDK-specific event types in tests, task routines, and event mapping.
  • Introduction of a new progress tracking mechanism in the event package with updated status and percentage computations.
  • Updates to supernode adapter tests and cache status assignments to align with the new event and progress patterns.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/system/e2e_cascade_test.go Updated event type checks to use new SDK event types.
sdk/task/task.go Renamed EmitEvent to emitEvent and adjusted LogEvent calls to use sdk events.
sdk/task/manager.go Modified task status updates and switched event types for task life cycle.
sdk/task/cascade.go Updated SDK log events during cascade task execution and registration.
sdk/task/cache.go Consistently uses event package status constants in task cache management.
sdk/event/types.go Replaced old event types with new SDK event types; introduced new supernode events.
sdk/event/progress.go Added comprehensive progress reporting logic with percentage mapping.
sdk/adapters/supernodeservice/types_test.go Adjusted tests to expect new event type mappings for supernode events.
sdk/adapters/supernodeservice/adapter.go Updated event mapping to align with new event names.

@mateeullahmalik mateeullahmalik merged commit 440274a into master May 19, 2025
7 checks passed
@mateeullahmalik mateeullahmalik deleted the sdk-progress-tracking branch May 27, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants