Replace --persist flag with REPLACE_PLAYLIST .env, Remove stale persist toggles#191
Open
dammitjeff wants to merge 5 commits into
Open
Replace --persist flag with REPLACE_PLAYLIST .env, Remove stale persist toggles#191dammitjeff wants to merge 5 commits into
dammitjeff wants to merge 5 commits into
Conversation
…irst time startup
… and PlaylistCard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PERSIST was incredibly confusing for users and devs to understand whats going on, and made it difficult to debug features since true meant "don't delete" false meant "delete and replace." The UI already had to double-invert just for it to make sense for end-users. Not good lol.
Swapped out the
--persistflag with a new env, and wired it up to thesettings.jsxpage.REPLACE_PLAYLIST=true- Delete old playlist, Create new one (this is now default)REPLACE_PLAYLIST=false- Keep old playlist, Create new one alongside old playlistAlso added a one time migration in
server.goto help convert existing "persist" values for anyone that was already using it, on startup. Will delete at a later date once people are migrated over.Also removed stale --persist toggles in the frontend as they're now redundant with the toggles in settings.