Fix playlist cards and tracklists not refreshing after a run in frontend#190
Open
dammitjeff wants to merge 2 commits into
Open
Fix playlist cards and tracklists not refreshing after a run in frontend#190dammitjeff wants to merge 2 commits into
dammitjeff wants to merge 2 commits into
Conversation
… run, moved up tracklist pull priority in run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where playlists cards and tracklists wouldn't show newly-pulled tracks until both A) A run was complete from start to finish, and B) You manually refreshed the page.
Currently the tracklist was saved too late in the run, meaning that if a run didn't properly complete, the new tracklist would never actually save to explo, causing a stale tracklist to show in the frontend. I moved
WritePlaylistCacheup to right after the tracklist is pulled from ListenBrainz, before any download tasks. Now the new tracklist is saved the moment it's fetched, so if a run fails, it still pulls the new tracklist for the user.The frontend only fetched tracks on mount and held them, but never properly updated. So even if a run was successfully completed, you had to reload to see them. Added
clearPlaylistCachefunction to wipe the old tracklist and refresh the tracklist so the new songs show up immediately, with no refresh needed.Also added
Pulling playlistandSaved playlistlog lines so users can see exactly when the new tracks were pulled.