Skip to content

Refactor review list queries and mutation handling #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LuisMSuarez merged 1 commit into from
Oct 29, 2025
Merged

Refactor review list queries and mutation handling #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 15 additions & 22 deletions packages/client/src/components/reviews/ReviewList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,12 @@ type SummarizeResponse = {
};

const ReviewList = ({ productId }: Props) => {
const {
mutate: handleSummarize,
isPending: generatingSummary,
isSuccess: summaryRegenerated,
isError: summaryGenError,
} = useMutation<SummarizeResponse>({
const reviewSummaryMutation = useMutation<SummarizeResponse>({
mutationFn: () => generateSummary(),
});

const {
data: reviewData,
isLoading,
error,
} = useQuery<GetReviewsResponse>({
queryKey: ['reviews', productId, summaryRegenerated],
const getReviewsQuery = useQuery<GetReviewsResponse>({
queryKey: ['reviews', productId, reviewSummaryMutation.isSuccess],
queryFn: () => fetchReviews(),
});

Expand All @@ -59,7 +50,7 @@ const ReviewList = ({ productId }: Props) => {
return data;
};

if (isLoading) {
if (getReviewsQuery.isLoading) {
return (
<div className="flex flex-col gap-5">
{[1, 2, 3].map((placeholder) => (
Expand All @@ -69,42 +60,44 @@ const ReviewList = ({ productId }: Props) => {
);
}

if (error) {
if (getReviewsQuery.error) {
return (
<p className="text-red-500">
Could not fetch reviews, please try again.
</p>
);
}

if (!reviewData?.reviews.length) {
if (!getReviewsQuery.data?.reviews.length) {
return null;
}

return (
<div>
<div id="summary" className="mb-5">
{reviewData?.summary ? (
<p>{reviewData.summary}</p>
) : generatingSummary ? (
{getReviewsQuery.data?.summary ? (
<p>{getReviewsQuery.data?.summary}</p>
) : reviewSummaryMutation.isPending ? (
<div>
<ReviewSkeleton />
</div>
) : (
<Button
onClick={() => handleSummarize()}
onClick={() => reviewSummaryMutation.mutate()}
className="cursor-pointer"
>
<HiSparkles className="text-yellow-400" />
Summarize
</Button>
)}
{summaryGenError && (
<p className="text-red-500">{summaryGenError}</p>
{reviewSummaryMutation.isError && (
<p className="text-red-500">
Could not generate review summary, please try again.
</p>
)}
</div>
<div id="reviewlist" className="flex flex-col gap-5">
{reviewData?.reviews.map((review) => (
{getReviewsQuery.data?.reviews.map((review) => (
<div key={review.id}>
<div className="font-semibold">{review.author}</div>
<div>
Expand Down