Skip to content

fix: Make dependency installation optional in Makefile#6

Open
LuisAPI wants to merge 1 commit intomainfrom
fix/install-optional
Open

fix: Make dependency installation optional in Makefile#6
LuisAPI wants to merge 1 commit intomainfrom
fix/install-optional

Conversation

@LuisAPI
Copy link
Owner

@LuisAPI LuisAPI commented Jul 13, 2025

Summary
Modified the start-backend target in the Makefile to make dependency
installation optional, improving developer experience by allowing faster
startup when dependencies are already installed.

  • Modified start-backend target: Now runs without dependency
    installation by default
    • Added optional dependency installation: Use make start-backend DEPS=true to install dependencies before starting
      • Improved developer workflow: Developers can now start the
        backend immediately if dependencies are already installed

        Usage

        # Start backend without installing dependencies (default)
        make start-backend
        
        # Start backend with dependency installation
        make start-backend DEPS=true

        Benefits

        • Faster development cycles: No need to wait for dependency
          installation on subsequent runs
      • Flexible workflow: Developers can choose when to install
        dependencies

        • Backward compatibility: Original behavior still
          available with DEPS=true parameter

          Testing

          • make start-backend starts backend without installing
            deps
            • make start-backend DEPS=true installs deps and
              starts backend
          • ✅ Existing make start command continues to work as
            expected

Summary by Sourcery

Make the Makefile start-backend target skip dependency installation by default and add an optional DEPS flag to install dependencies when needed

Enhancements:

  • Remove mandatory dependency installation from start-backend target
  • Add DEPS=true option to control when dependencies are installed before starting the backend

Summary
Modified the `start-backend` target in the Makefile to make dependency
installation optional, improving developer experience by allowing faster
startup when dependencies are already installed.

- **Modified `start-backend` target**: Now runs without dependency
  installation by default
  - **Added optional dependency installation**: Use `make start-backend
    DEPS=true` to install dependencies before starting
    - **Improved developer workflow**: Developers can now start the
      backend immediately if dependencies are already installed

      ## Usage
      ```bash
      # Start backend without installing dependencies (default)
      make start-backend

      # Start backend with dependency installation
      make start-backend DEPS=true
      ```

      ## Benefits
      - **Faster development cycles**: No need to wait for dependency
	installation on subsequent runs
	- **Flexible workflow**: Developers can choose when to install
	  dependencies
	  - **Backward compatibility**: Original behavior still
	    available with `DEPS=true` parameter

	    ## Testing
	    - ✅ `make start-backend` starts backend without installing
	      deps
	      - ✅ `make start-backend DEPS=true` installs deps and
		starts backend
		- ✅ Existing `make start` command continues to work as
		  expected
@LuisAPI LuisAPI added the enhancement New feature or request label Jul 13, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 13, 2025

Reviewer's Guide

The PR refactors the Makefile’s start-backend target to drop its mandatory install-deps prerequisite and introduce a DEPS flag for optional dependency installation, allowing faster backend startup when dependencies are already present.

File-Level Changes

Change Details Files
Convert start-backend target to use optional dependency installation
  • Removed the install-deps prerequisite from start-backend
  • Added a DEPS=true conditional block to install dependencies only when requested
  • Updated comments and usage instructions to reflect the new flag
Makefile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LuisAPI - I've reviewed your changes - here's some feedback:

  • Consider renaming the DEPS variable to something like INSTALL_DEPS for clearer intent and to avoid possible naming conflicts.
  • For readability and maintainability, you might use Makefile’s native conditional syntax (ifeq/endif) instead of embedding a shell if block.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider renaming the `DEPS` variable to something like `INSTALL_DEPS` for clearer intent and to avoid possible naming conflicts.
- For readability and maintainability, you might use Makefile’s native conditional syntax (ifeq/endif) instead of embedding a shell `if` block.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant