fix(scripts): honour ISSUE_LABELS override in create-v1-issues#187
Merged
Conversation
ISSUE_LABELS was documented but never read; label assignment always fell back to the per-issue hard-coded values. Parse the env var once at startup and use it in place of the per-issue labelsCsv when provided. https://claude.ai/code/session_01Hb3fsTVx9MxAaE6iTbiLt2
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b3b806911
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A single page fetch silently missed milestones beyond position 100. Now pages until the title is found or the list is exhausted. https://claude.ai/code/session_01Hb3fsTVx9MxAaE6iTbiLt2
Coverage report
Floors live in |
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(cat <<'EOF'
Summary
ISSUE_LABELSenv var was documented but never readISSUE_LABELSonce at startup and uses it as a full replacement for per-issue hard-coded labels when setlabelsCsvwhenISSUE_LABELSis not provided (no behaviour change for existing callers)Test plan
ISSUE_LABELSset — labels come from per-issue defaults as beforeISSUE_LABELS=v1,my-custom-label— all issues receive only those labelshttps://claude.ai/code/session_01Hb3fsTVx9MxAaE6iTbiLt2
EOF
)
Generated by Claude Code