Skip to content

convert long numbers to strings in response#131

Open
jwillinghalpern wants to merge 3 commits intomasterfrom
feature-longnumbers
Open

convert long numbers to strings in response#131
jwillinghalpern wants to merge 3 commits intomasterfrom
feature-longnumbers

Conversation

@jwillinghalpern
Copy link
Copy Markdown
Collaborator

adds a new convertLongNumbersToStrings option to Filemaker.create(). Setting this to true converts long numbers such as those produced by FileMaker's Get(uuidNumber) and Random functions into strings rather than returning scientific notation with reduced precision.

This is the issue which prompted this feature: Luidog/node-red-contrib-filemaker#61. I haven't checked if fixing fms-api-client alone addresses the issue fully because I haven't tried this change with node red.

This part of the changed code felt a bit repetitive, not of a better way offhand though:

parseScriptResult(body, this.agent.convertLongNumbersToStrings)

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 4, 2022

Coverage Status

Coverage increased (+0.006%) to 99.446% when pulling 9fbb585 on feature-longnumbers into 753bbda on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants