Suggested changes from proofreading review (fiverr.com/textandtables/)

[textandtables]

Test Change to Transitions & Workflows (added line 6)

[augustak]

Hi @textandtables ,

Thank you for many great changes! However, it looks like you have removed the table of contents as well as some illustrations. Can you have a look? Also, anything in the 'reference' section is autogenerated into this repository and shouldn't be edited in this repository directly but rather in their respective origin repository. Can you remove those changes from this PR and optionally add them back to their respective repositories?

https://github.com/LucidtechAI/las-cli
https://github.com/LucidtechAI/las-sdk-python
https://github.com/LucidtechAI/las-sdk-net
https://github.com/LucidtechAI/las-sdk-java
https://github.com/LucidtechAI/las-sdk-js

I will start reviewing once those things have been fixed :-)

[textandtables]

Hi @augustak -

Thank you for your feedback on my review. I apologize for any difficulties that I may have caused.

Regarding the table of contents, I did not see a section with this name while I was reviewing the changes, so if you could point me to the correct page where this is located or the change number that I have added, I will be happy to address it. As fyi, I have made all the changes via GitHub not GitBook, per my discussions with @staalezh. I’m not sure if that’s relevant to how the table of contents are displayed.

Regarding the reference section, I’m sorry that I was not aware that these should not be changed. I am happy to provide my suggestions in an alternate form (if you could be so kind as to provide me instructions), and then I will remove the changes from GitHub.

For clarity, my understanding is that this encompasses my 12 changes under las-docs /reference with filenames latest.md and README.md, with the initial ID’s below, that I made on Jun 22, 2021:
0fe80b8
f75fc11
0d1c504
89887ff
3de4056
ca9261f
dda2d79
d38ae77
57f08d5
9a7376f
0594a76
0680a66

Thanks in advance. I look forward to your feedback.
Best,
Chris

[augustak]

Hi @augustak -

Thank you for your feedback on my review. I apologize for any difficulties that I may have caused.

Regarding the table of contents, I did not see a section with this name while I was reviewing the changes, so if you could point me to the correct page where this is located or the change number that I have added, I will be happy to address it. As fyi, I have made all the changes via GitHub not GitBook, per my discussions with @staalezh. I’m not sure if that’s relevant to how the table of contents are displayed.

Regarding the reference section, I’m sorry that I was not aware that these should not be changed. I am happy to provide my suggestions in an alternate form (if you could be so kind as to provide me instructions), and then I will remove the changes from GitHub.

For clarity, my understanding is that this encompasses my 12 changes under las-docs /reference with filenames latest.md and README.md, with the initial ID’s below, that I made on Jun 22, 2021:
0fe80b8
f75fc11
0d1c504
89887ff
3de4056
ca9261f
dda2d79
d38ae77
57f08d5
9a7376f
0594a76
0680a66

Thanks in advance. I look forward to your feedback.
Best,
Chris

Hi Chris,

It looks like "Gitbook" has made the changes that removed table of contents and illustrations. Can you try reverting the following commits:

• 5532f08
• e1970a6
• 4f63ae9

I deployed your fork here so that you can view how your changes will be reflected on the website.

You are correct that the 'reference' section I'm referring to is located in the '/reference' folder (and subfolders) and that you can revert those changes in this repository, but add them in their respective location in the SDK/CLI repositories that I have linked above.

Sorry for the inconvenience,

Best,
August

[textandtables]

Hi @augustak and thanks for your feedback. I was off for a US holiday and just returning to work today. Please give me 1-2 days to review and follow your suggestions. Thanks.

[textandtables]

Hi @augustak,

Thank you again for taking a look at this and for your suggestions to resolve the issues.

I see the first commit (5532f08) covers the missing images, a README file (for which I only made a minor suggestion) and a SUMMARY file (which I did not intentionally update). But as I am not a GitHub expert, I would appreciate instructions on how to revert my commits - I don’t see a way to do this. Regarding the reference section, please clarify where you would like my suggested changes moved to. I’m happy also to revert those commits to avoid any conflicts for you.

Thanks in advance,
Chris