get item from localStorage only when the cache is enabled#351
Open
LouaiTrabulsi wants to merge 1 commit intoLucasBassetti:masterfrom
Open
get item from localStorage only when the cache is enabled#351LouaiTrabulsi wants to merge 1 commit intoLucasBassetti:masterfrom
LouaiTrabulsi wants to merge 1 commit intoLucasBassetti:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to use the chatbot in an environment that doesn't support localStorage.
I saw you are using localStorage for caching purpose, for my case I don't need cache so I leave it as default (disabled), but I realized that in file 'storage.js' you are accessing the localStorage before checking if the cache is enabled:
const unParsedCache = localStorage.getItem(cacheName);so I just moved this line to be after checking if cache is enbled:
this way I will not get an error related to localStorage in my environment.
Thanks in advance