feat(eslint-config): add node and jest support #6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| module.exports = { | ||
| extends: [ | ||
| './index.js', | ||
| ], | ||
| parser: 'babel-eslint', | ||
| env: { | ||
| browser: true, | ||
| }, | ||
| rules: { | ||
| 'no-console': ['error', { allow: ['warn', 'error'] }], | ||
|
|
||
| // common ones | ||
| // biblio | ||
| semi: ['error', 'never'], | ||
| quotes: [ | ||
| 'error', | ||
| 'single', | ||
| { avoidEscape: true, allowTemplateLiterals: true }, | ||
| ], | ||
|
|
||
| // wf | ||
| 'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off', | ||
|
|
||
| // ydr | ||
|
|
||
| // bib-service-projects | ||
| 'require-atomic-updates': 'warn', | ||
| }, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,56 +1,38 @@ | ||
| const prettierConfig = require('@lovetoknow/prettier-config') | ||
|
|
||
| module.exports = { | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:prettier/recommended', | ||
| './jest.js', | ||
| ], | ||
| env: { | ||
| es6: true, | ||
| }, | ||
| parserOptions: { | ||
| ecmaVersion: 2018, | ||
| }, | ||
| rules: { | ||
| // Best Practices | ||
| curly: 'error', | ||
| eqeqeq: 'error', | ||
|
|
||
| // Stylistic (although Prettier will handle most of it) | ||
| 'brace-style': ['error', '1tbs', { allowSingleLine: true }], | ||
| 'one-var': ['error', 'never'], | ||
| 'linebreak-style': ['error', 'unix'], | ||
|
|
||
| // ES6 | ||
| 'no-duplicate-imports': 'error', | ||
| 'no-useless-constructor': 'error', | ||
| 'prefer-template': 'error', | ||
|
|
||
| // Prettier config | ||
| 'prettier/prettier': [ | ||
| 'error', | ||
| { | ||
| ...prettierConfig, | ||
| }, | ||
| ], | ||
| }, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| module.exports = { | ||
| overrides: [ | ||
| { | ||
| files: ['*.spec.js', '*.test.js'], | ||
| env: { | ||
| jest: true, | ||
| }, | ||
| extends: ['plugin:jest/recommended'], | ||
| plugins: ['jest'], | ||
|
Comment on lines
+8
to
+9
Contributor
There was a problem hiding this comment. This requires us to have the |
||
| }, | ||
| ], | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| module.exports = { | ||
| extends: [ | ||
| './index.js', | ||
| 'plugin:node/recommended', | ||
| ], | ||
| plugins: ['node'], | ||
|
Comment on lines
+4
to
+6
Contributor
There was a problem hiding this comment. same here with https://www.npmjs.com/package/eslint-plugin-node |
||
| env: { | ||
| node: true, | ||
| es2022: true, | ||
| }, | ||
| parserOptions: { | ||
| ecmaVersion: 2022, | ||
| }, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that these were originally linked to specific projects still makes them suitable for node or jest environments, I would move them to the shared file 🙏🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just remove (or have as a goal to remove eventually) anything for specific projects and have those projects just override any of the default settings they want to be diff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I didn't include 100% of their rules. Only the ones that I considered to be best practices. And also,
semiandquotesmatch the prettier config. So we don't have issues using prettier-config and eslint-config together, which is what I'd recommend.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The references to different projects are left there only to indicate that we did a "merge" of all the different preferences everyone had. To highlight that it was done as democratically as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing it again, these rules that were in the index.js file are all good for node.js, including the extended configurations.