[1.20.1] A few small bug fixes#2456
Merged
Lothrazar merged 6 commits intoLothrazar:trunk/1.20.1from Jan 7, 2025
Merged
Conversation
…mode without corners set
The current positioning of the fake player at the Miner corner means that the Mattock behaviour will inconsistently apply based on the distance and only in relative negative coordinates.
Lothrazar
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a collection of a few small but random fixes to bugs we noticed while playing with Cyclic on a server - I thought it makes more sense to just make one PR than a bunch of tiny ones, but happy to split it up if that is preferred!
Particularly, the last commit addresses an inconsistency with Mattocks in Miners - but I'm not sure how it is supposed to behave by design. If this needs some more thought especially, I can move that out or drop the commit 🙂
Also not sure if the 1.20.1 branch is the right one to PR to - but if not, am happy to rebase it :)
The bugs addressed: