Skip to content

feat: (FontType) Preserve tags on new lines#60

Closed
Collin-M wants to merge 1 commit intoLostCityRS:254from
Collin-M:fonttype-fix
Closed

feat: (FontType) Preserve tags on new lines#60
Collin-M wants to merge 1 commit intoLostCityRS:254from
Collin-M:fonttype-fix

Conversation

@Collin-M
Copy link
Copy Markdown
Contributor

WIP until reviewed, otherwise works good in my testing.

  • For 254+

Currently, while using split_init and split_get (in quest journals specifically)
You have to readd a text decorator tag (@dre@, @dbl@, @str@, etc) on every new line, whether it's an automatic split based on length or manual with a |.

I think this should be adjusted so that every new line should carry over the last tag of the previous line based on line breaks in quest journals and interface size changes over time. The strikethrough tag should only carry over through automatic line breaks, not manual line breaks. Below is an example.


Step 10 - RS3:
image
Step 10 - OSRS:
image

Step 20 - RS3:
image
Step 20 - OSRS:
image

Based on these screenshots, it would appear that the line breaks are only inserted at the end of a phrase/paragraph (in the above example, the word "fear."), rather than manually. I have doubts that these journals were all reworked each time the interface changed to make the line breaks fit properly (and maintaining formatting).

To do this currently:
Step 10: @dre@Lucien@dbl@ has asked me to retrieve the @dre@Staff of Armadyl@dbl@ from|@dbl@the @dre@Temple of Ikov@dbl@. The entrance is near @dre@Hemenster@dbl@. He has|@dbl@given me a @dre@pendant@dbl@ so I can enter the @dre@chamber of fear.
Step 20: @str@Lucien has asked me to retrieve the Staff of Armadyl from|@str@the Temple of Ikov. The entrance is near Hemenster. He has|@str@given me a pendant so I can enter the chamber of fear.

After this PR:
Step 10: @dre@Lucien@dbl@ has asked me to retrieve the @dre@Staff of Armadyl@dbl@ from the @dre@Temple of Ikov@dbl@. The entrance is near @dre@Hemenster@dbl@. He has given me a @dre@pendant@dbl@ so I can enter the @dre@chamber of fear.
Step 20: @str@Lucien has asked me to retrieve the Staff of Armadyl from the Temple of Ikov. The entrance is near Hemenster. He has given me a pendant so I can enter the chamber of fear.

@Collin-M Collin-M marked this pull request as draft December 16, 2025 03:14
@Collin-M Collin-M changed the title WIP: (FontType) Preserve tags on new lines feat: (FontType) Preserve tags on new lines Dec 16, 2025
@Collin-M Collin-M closed this Jan 29, 2026
@Collin-M Collin-M deleted the fonttype-fix branch January 29, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant