feat: (FontType) Preserve tags on new lines#60
Closed
Collin-M wants to merge 1 commit intoLostCityRS:254from
Closed
feat: (FontType) Preserve tags on new lines#60Collin-M wants to merge 1 commit intoLostCityRS:254from
Collin-M wants to merge 1 commit intoLostCityRS:254from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP until reviewed, otherwise works good in my testing.
Currently, while using
split_initandsplit_get(in quest journals specifically)You have to readd a text decorator tag (
@dre@, @dbl@, @str@, etc) on every new line, whether it's an automatic split based on length or manual with a|.I think this should be adjusted so that every new line should carry over the last tag of the previous line based on line breaks in quest journals and interface size changes over time. The strikethrough tag should only carry over through automatic line breaks, not manual line breaks. Below is an example.
Step 10 - RS3:


Step 10 - OSRS:
Step 20 - RS3:


Step 20 - OSRS:
Based on these screenshots, it would appear that the line breaks are only inserted at the end of a phrase/paragraph (in the above example, the word "fear."), rather than manually. I have doubts that these journals were all reworked each time the interface changed to make the line breaks fit properly (and maintaining formatting).
To do this currently:
Step 10:
@dre@Lucien@dbl@ has asked me to retrieve the @dre@Staff of Armadyl@dbl@ from|@dbl@the @dre@Temple of Ikov@dbl@. The entrance is near @dre@Hemenster@dbl@. He has|@dbl@given me a @dre@pendant@dbl@ so I can enter the @dre@chamber of fear.Step 20:
@str@Lucien has asked me to retrieve the Staff of Armadyl from|@str@the Temple of Ikov. The entrance is near Hemenster. He has|@str@given me a pendant so I can enter the chamber of fear.After this PR:
Step 10:
@dre@Lucien@dbl@ has asked me to retrieve the @dre@Staff of Armadyl@dbl@ from the @dre@Temple of Ikov@dbl@. The entrance is near @dre@Hemenster@dbl@. He has given me a @dre@pendant@dbl@ so I can enter the @dre@chamber of fear.Step 20:
@str@Lucien has asked me to retrieve the Staff of Armadyl from the Temple of Ikov. The entrance is near Hemenster. He has given me a pendant so I can enter the chamber of fear.