chore: Port FM, Fish, Herb, Mining, Prayer, Smithing, Thieving#367
Merged
Pazaz merged 9 commits intoLostCityRS:377-wipfrom Jan 13, 2026
Merged
chore: Port FM, Fish, Herb, Mining, Prayer, Smithing, Thieving#367Pazaz merged 9 commits intoLostCityRS:377-wipfrom
Pazaz merged 9 commits intoLostCityRS:377-wipfrom
Conversation
Author
|
This PR is now ready for approval after queue* (the queue() version with args) is available in 377 |
Macs-Account
changed the title
Author
|
Followed slayer implementation convention for handling queue* by using queue and leaving a comment todo that it should be changed when available. Builds locally, ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firemaking, Fishing, Herblore, Mining, prayer, Smithing, Thieving and supporting work added.
Added a clearly named temporary stub class for a couple quest/area labels. When these things are implemented (probably by me) they can just be deleted.