chore: Port scripts/skill_crafting#358
Conversation
|
multiobj3_close and multiobj3 are no longer valid, as those interface styles used in leather, pottery, glass crafting are totally new since 254. I left them as stubs. The features using them would never work with a 254 anyway so it's not a functionality loss, and this way all the other supporting work for those features is present. What is TEMP_HOLDING?
I think 1) is the better option Edit: Also, after implementing tutorial island, my stubs method is definitely the way to go. The most frustrating part of porting and testing tutorial island was, by far and away, the fact that things that didn't compile were just commented out or not included at all in 377. Things would just not work for no discernable reason, and after half an hour of poking around realize that a line in some random file wasn't copied because it wouldn't have compiled. If I could have gotten a nice clean "duplicate entry" compiler error those things would have taken 5 seconds instead of 30-45 minutes. It also stressed me out knowing that I had to test every nook and cranny because some random little line somewhere might be missing and now something doesn't work even though all the other supporting work exists |
…ality change from before, as crafting leather/glass/pottery didn't exist before this PR at all
|
Builds locally, ready for review. See previous comment as well |
|
@Pazaz I know that the new interface stuff in the engine that came out in 270 isn't fully ready in this PR. but since it has the framework and infrastructure for everything else in crafting and my other PRs which fill out the infrastructure of the project are waiting on the work in here to be merged could it get merged in? It would be very helpful for future development to have this infrastructure in, and #374 #375 are becoming conflict magnets the longer they sit (and a high risk of forcing duplicated work by other developers) |
Port over skills_crafting with supporting work
Also implement onyx, onyx jewelry, plantpot firing, pot lid firing, magic root spinning, lanterns, lamps, fishbowls, lantern lenses configs