Skip to content

chore: Port scripts/skill_crafting#358

Merged
Pazaz merged 19 commits intoLostCityRS:377-wipfrom
Macs-Account:patch-4
Feb 6, 2026
Merged

chore: Port scripts/skill_crafting#358
Pazaz merged 19 commits intoLostCityRS:377-wipfrom
Macs-Account:patch-4

Conversation

@Macs-Account
Copy link
Copy Markdown

@Macs-Account Macs-Account commented Jan 4, 2026

Port over skills_crafting with supporting work

Also implement onyx, onyx jewelry, plantpot firing, pot lid firing, magic root spinning, lanterns, lamps, fishbowls, lantern lenses configs

@Macs-Account
Copy link
Copy Markdown
Author

Macs-Account commented Jan 5, 2026

multiobj3_close and multiobj3 are no longer valid, as those interface styles used in leather, pottery, glass crafting are totally new since 254. I left them as stubs. The features using them would never work with a 254 anyway so it's not a functionality loss, and this way all the other supporting work for those features is present.

What is TEMP_HOLDING?
Crafting is used in fletching as well as some quests. Your options are either:

  1. Add stubs for those things with a comment explaining them and the implementer of those features (probably me) can remove the duplicates from the temp file
  2. Implement Crafting, Fletching, those quests, AND any OTHER supporting work for those in one PR (as they likely also require crafting to function -- chicken and egg situation) resulting in one mega-pr that touches a huge amount of the code base and causes a merge conflict nightmare if it isn't approved immediately

I think 1) is the better option

Edit: Also, after implementing tutorial island, my stubs method is definitely the way to go. The most frustrating part of porting and testing tutorial island was, by far and away, the fact that things that didn't compile were just commented out or not included at all in 377. Things would just not work for no discernable reason, and after half an hour of poking around realize that a line in some random file wasn't copied because it wouldn't have compiled. If I could have gotten a nice clean "duplicate entry" compiler error those things would have taken 5 seconds instead of 30-45 minutes. It also stressed me out knowing that I had to test every nook and cranny because some random little line somewhere might be missing and now something doesn't work even though all the other supporting work exists

@Macs-Account Macs-Account marked this pull request as ready for review January 5, 2026 17:07
@Macs-Account Macs-Account marked this pull request as draft January 6, 2026 20:50
@Macs-Account Macs-Account marked this pull request as ready for review January 9, 2026 05:56
@Macs-Account
Copy link
Copy Markdown
Author

Builds locally, ready for review. See previous comment as well

@Macs-Account
Copy link
Copy Markdown
Author

Macs-Account commented Jan 25, 2026

@Pazaz I know that the new interface stuff in the engine that came out in 270 isn't fully ready in this PR. but since it has the framework and infrastructure for everything else in crafting and my other PRs which fill out the infrastructure of the project are waiting on the work in here to be merged could it get merged in? It would be very helpful for future development to have this infrastructure in, and #374 #375 are becoming conflict magnets the longer they sit (and a high risk of forcing duplicated work by other developers)

@Pazaz Pazaz merged commit 4d8da4a into LostCityRS:377-wip Feb 6, 2026
1 check passed
@Macs-Account Macs-Account deleted the patch-4 branch February 21, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants