This repository was archived by the owner on Mar 18, 2019. It is now read-only.
修复 AuthPrivateKey.Address() bug 点，可能导致底层内存溢出。此修改配合 relay-lib 的 crypto.go#54
Open
af913337456 wants to merge 3 commits intoLoopringSecondary:masterfrom
Open
修复 AuthPrivateKey.Address() bug 点，可能导致底层内存溢出。此修改配合 relay-lib 的 crypto.go#54af913337456 wants to merge 3 commits intoLoopringSecondary:masterfrom
af913337456 wants to merge 3 commits intoLoopringSecondary:masterfrom
Conversation
修改 baseFilter 在 o.OrderType 为 types.ORDER_TYPE_MARKET 时候，客户端没传 priKey 时候导致 o.AuthPrivateKey.Address() 内部进入后在底层出错。因为原 Address() 没做指针判空。导致的现象就是，代码运行到改行，停止往下进行，无任何输出，也不崩溃。测试重现请按如下步骤即可。客户端的 orderType 传 mark 类型的，但是不传 AuthPrivateKey 。就能看到了。
address() 添加容错
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改 baseFilter 在 o.OrderType 为 types.ORDER_TYPE_MARKET 时候，客户端没传 priKey 时候导致 o.AuthPrivateKey.Address() 内部进入后在底层出错。因为原 Address() 没做指针判空。导致的现象就是，代码运行到改行，停止往下进行，无任何输出，也不崩溃。测试重现请按如下步骤即可。客户端的 orderType 传 mark 类型的，但是不传 AuthPrivateKey 。就能看到了。