Address code review feedback from PR #16 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>
lachlangrose
merged commit 184369e
into
fix/adding-implicit-function-cutting
48 checks passed
Copilot
AI
changed the title
[WIP] Add option to clip surface with implicit function
Address code review feedback from PR #16
Nov 4, 2025
lachlangrose
added a commit
that referenced
this pull request
Nov 4, 2025
* fix: add copy method and vtk method for trimesh object * chore: ignore windows build * fix: specify .so for unix and pyd for windows * ci: rename examples and adding test suite + git action * fix: adding option to cut surface with a property this is interpreted as a signed distance function and could be evaluated on the triangle nodes from an implicit function. Note if the surface is remeshed the property values will need to be re-evaluated on the new nodes. * fix: move checks to separate file and add import/export from np arrays * ci: use loop python versions (#15) * ci: adding windows/mac tests * ci: use c:: for vcpkg and revert to loop python env var * ci: use env var for mac as well * ci: update windows cmake instructions * Update environment variable for vcpkg toolchain Set VCPKG_ROOT environment variable for package build. * test: update test ci runner to use pypi runner template * tests: add cgal/eigen to nix * fix: specify python versions * fix: use exact meshes for clipping, avoid infinite hangs * fix: set default kernel to exact, use double for speed at risk of hanging ci: change name of tester to testing * Update examples/cut_example.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [WIP] Add option to clip surface with implicit function (#17) * Initial plan * Address code review comments Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com> * fix: add dlls to package for wheel * tests: remove tmp files --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies code style and correctness fixes identified in the code review for the implicit function clipping feature.
Code Style Fixes
src/meshutils.h,src/mesh.cpp,tests/test_mesh_operations.pyloop_cgal/__init__.pypyvistaimport inexamples/cut_example.pyConfiguration Fixes
pyproject.tomlto use proper nested table format for[project.optional-dependencies]startsWith(matrix.os, 'macos')instead of invalid||operatorLogic Corrections
KEEP_POSITIVE_SIDEfiltering fromv <= valuetov < valueinsrc/mesh.cppto correctly exclude negative side while preserving boundary-> boolreturn type annotation fromvalidate_vertices_and_faces()(raisesValueErroron failure, doesn't returnFalse)Build System
.sosuffix unconditionally before overriding for Windows💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.