fix: include recommended query fields for 'view' event modal#3168
Open
msmithstubbs wants to merge 1 commit intoLogflare:mainfrom
Open
fix: include recommended query fields for 'view' event modal#3168msmithstubbs wants to merge 1 commit intoLogflare:mainfrom
msmithstubbs wants to merge 1 commit intoLogflare:mainfrom
Conversation
msmithstubbs
changed the title
Contributor
|
under observation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix a reported bug that would result in the event modal showing "not found" while the permalink works correctly. I haven't been able to reproduce the bug so this is a speculative fix.
Both code paths call
LogEvents.get_event_with_fallbackso I don't think the issue is related to the cache.One difference was the 'view' link wasn't including recommended fields. It's possible the user was working with a BigQuery table that required a field to be selected that wasn't.
I haven't included tests for this change, but can if requested. It would simply be a regex on the event anchor element.
ANL-1368