Skip to content

chore: remove warnings related to distinct types for compile time config vars #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ziinc merged 1 commit into from
Feb 24, 2026
Merged

chore: remove warnings related to distinct types for compile time config vars #3166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions priv/repo/migrations/20210322193905_rename_columns_for_mnesia_compatibility.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
defmodule Logflare.Repo.Migrations.RenameColumnsForMnesiaCompatibility do
use Ecto.Migration

@env Application.compile_env(:logflare, :env)

def change do
alter table(:users) do
add :billing_enabled, :boolean, null: false, default: false
end

execute(~s|UPDATE users SET billing_enabled = "billing_enabled?"|)

if @env in [:dev, :test] do
if env() in [:dev, :test] do
alter table(:users) do
remove :billing_enabled?, :boolean, null: false, default: false
end
Expand All @@ -22,7 +20,7 @@ defmodule Logflare.Repo.Migrations.RenameColumnsForMnesiaCompatibility do

execute(~s|UPDATE saved_searches SET tailing = "tailing?"|)

if @env in [:dev, :test] do
if env() in [:dev, :test] do
alter table(:saved_searches) do
remove :tailing?, :boolean, null: false, default: true
end
Expand All @@ -35,11 +33,14 @@ defmodule Logflare.Repo.Migrations.RenameColumnsForMnesiaCompatibility do
execute(~s|UPDATE billing_accounts SET lifetime_plan = "lifetime_plan?"|)


if @env in [:dev, :test] do
if env() in [:dev, :test] do
alter table(:billing_accounts) do
remove :lifetime_plan?, :boolean, null: false, default: false
end
end
end

defp env do
Application.get_env(:logflare, :env)
end
end
10 changes: 7 additions & 3 deletions priv/repo/migrations/20210729161959_subscribe_to_postgres.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ defmodule Logflare.Repo.Migrations.SubscribeToPostgres do
"""

use Ecto.Migration

@disable_ddl_transaction true
@disable_migration_lock true
@username Application.compile_env(:logflare, Logflare.Repo)[:username]
@slot Application.compile_env(:logflare, Logflare.ContextCache.CacheBuster)[:replication_slot]
@env Application.compile_env(:logflare, :env)
@publications Application.compile_env(:logflare, Logflare.ContextCache.CacheBuster)[:publications]
@publication_tables [
"billing_accounts",
Expand All @@ -30,7 +30,7 @@ defmodule Logflare.Repo.Migrations.SubscribeToPostgres do
]

def up do
if @env in [:dev, :test] do
if env() in [:dev, :test] do
execute("ALTER SYSTEM SET wal_level = 'logical';")
execute("ALTER USER #{@username} WITH REPLICATION;")
end
Expand All @@ -56,9 +56,13 @@ defmodule Logflare.Repo.Migrations.SubscribeToPostgres do
# This is happening in `20210810182003_set_rules_to_replica_identity_full.exs`
# execute("alter table rules replica identity default")

if @env in [:dev, :test] do
if env() in [:dev, :test] do
execute("ALTER USER #{@username} WITH NOREPLICATION;")
execute("ALTER SYSTEM RESET wal_level;")
end
end

defp env do
Application.get_env(:logflare, :env)
end
end
Loading