Add React 19 support #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweber-lr
commented
Dec 11, 2025
Comment on lines
-13
to
+17
| return <div ref="button" onClick={() => {}} />; | ||
| return <div ref={this.buttonRef} onClick={() => {}} />; |
Contributor
Author
There was a problem hiding this comment.
I had to update our usage of refs in the test code since string-based refs are no longer allowed in React
sweber-lr
commented
Dec 11, 2025
| "peerDependencies": { | ||
| "logrocket": ">=2.0", | ||
| "react": ">=18", | ||
| "react-dom": ">=18" |
Contributor
Author
There was a problem hiding this comment.
The dependency on react-dom has been removed since we are no longer using the internal tools from it.
eranimo
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the logrocket-react package to be compatible with React 19 by no longer using the internal functions and instead directly looking at internal properties on click event targets. This has been tested to work on production builds of React.
I tested this by running
npm run build, thennpm packand then installed the generated package into a new React 19 test app and then ran that app using the production version of React and pointed it at theapphub/logrocketproject in PROD. You can see example sessions where the component name is captured and can filtered by here.I also added typings for the package and updated the README to include instructions on how to install the package for React 18 too.