Skip to content

build(cmake): Add opt-in install/export switch#38

Merged
ReenigneArcher merged 1 commit into
masterfrom
build/cmake/adjust-install-conditions
Jul 3, 2026
Merged

build(cmake): Add opt-in install/export switch#38
ReenigneArcher merged 1 commit into
masterfrom
build/cmake/adjust-install-conditions

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Introduce LIBVIRTUALHID_INSTALL to control whether install rules and CMake package exports are generated, defaulting to ON for top-level builds and OFF when vendored. Packaging and Windows driver install/package checks are now conditioned on install being enabled, and the README documents the new behavior and override flags.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Introduce `LIBVIRTUALHID_INSTALL` to control whether install rules and CMake package exports are generated, defaulting to ON for top-level builds and OFF when vendored. Packaging and Windows driver install/package checks are now conditioned on install being enabled, and the README documents the new behavior and override flags.
@ReenigneArcher ReenigneArcher force-pushed the build/cmake/adjust-install-conditions branch from 5cd3b87 to 030ab23 Compare July 3, 2026 15:36
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (5291f19) to head (030ab23).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   87.81%   89.77%   +1.96%     
==========================================
  Files          14       14              
  Lines        4235     4500     +265     
  Branches     1436     1511      +75     
==========================================
+ Hits         3719     4040     +321     
+ Misses        357      295      -62     
- Partials      159      165       +6     
Flag Coverage Δ
Linux-Clang 71.09% <ø> (-0.26%) ⬇️
Linux-GCC 83.61% <ø> (+0.19%) ⬆️
Windows-MSVC 90.22% <ø> (+2.39%) ⬆️
Windows-MinGW-UCRT64 82.15% <ø> (+2.47%) ⬆️
macOS 70.94% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8072a...030ab23. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit 0b143e3 into master Jul 3, 2026
25 checks passed
@ReenigneArcher ReenigneArcher deleted the build/cmake/adjust-install-conditions branch July 3, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant