Skip to content

feat(input): implement libvirtualhid#5368

Draft
ReenigneArcher wants to merge 1 commit into
masterfrom
libvirtualhid
Draft

feat(input): implement libvirtualhid#5368
ReenigneArcher wants to merge 1 commit into
masterfrom
libvirtualhid

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

This PR implements libvirtualhid in Sunshine, replacing inputtino on Linux, vigembus on Windows AMD64, but still falling back to vigembus on Windows ARM64.

TODO:

  • CI/CD passing
  • Sonar
  • Test coverage
  • Testing
    • Windows
      • Gamepads
      • Keyboard
      • Mouse
      • Touch
      • Pen
    • Linux
      • Gamepads
      • Keyboard
      • Mouse
      • Touch
      • Pen
    • FreeBSD
      • Gamepads
      • Keyboard
      • Mouse
      • Touch
      • Pen
  • Remove vigembus helpers from web-ui
  • Create release of libvirtualhid
  • Publish libvirtualhid driver to MSFT store

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher changed the title feat: implement libvirtualhid feat(input): implement libvirtualhid Jul 3, 2026
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 1.21kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 855.75kB 1.21kB (0.14%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/createLucideIcon-*.js 240 bytes 358.7kB 0.07%
assets/config-*.js 969 bytes 70.65kB 1.39%

Files in assets/config-*.js:

  • ./src_assets/common/assets/web/config.html → Total Size: 0 bytes

@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
19 New issues
19 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 2.11382% with 602 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@92a9230). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/virtualhid_input.cpp 1.61% 472 Missing and 15 partials ⚠️
src/platform/linux/input/virtualhid.cpp 6.45% 55 Missing and 3 partials ⚠️
src/platform/windows/input.cpp 1.78% 50 Missing and 5 partials ⚠️
src/config.cpp 0.00% 1 Missing ⚠️
src/input.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5368   +/-   ##
=========================================
  Coverage          ?   26.94%           
=========================================
  Files             ?      107           
  Lines             ?    25625           
  Branches          ?    11225           
=========================================
  Hits              ?     6904           
  Misses            ?    16843           
  Partials          ?     1878           
Flag Coverage Δ
FreeBSD-amd64 12.45% <1.69%> (?)
Homebrew-macos-14 21.01% <0.00%> (?)
Homebrew-macos-15 21.17% <0.00%> (?)
Homebrew-macos-26 21.29% <0.00%> (?)
Homebrew-ubuntu-24.04 12.90% <2.00%> (?)
Linux-AppImage 12.25% <2.00%> (?)
Windows-AMD64 14.77% <1.64%> (?)
Windows-ARM64 12.85% <0.96%> (?)
macOS-arm64 19.28% <0.00%> (?)
macOS-x86_64 18.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.h 0.00% <ø> (ø)
src/config.cpp 24.00% <0.00%> (ø)
src/input.cpp 18.86% <0.00%> (ø)
src/platform/windows/input.cpp 0.33% <1.78%> (ø)
src/platform/linux/input/virtualhid.cpp 6.45% <6.45%> (ø)
src/platform/virtualhid_input.cpp 1.61% <1.61%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a9230...ab049ba. Read the comment docs.

@ReenigneArcher ReenigneArcher force-pushed the libvirtualhid branch 2 times, most recently from c8a5174 to 444f42a Compare July 3, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment