Skip to content
This repository was archived by the owner on Jun 29, 2023. It is now read-only.

[ DEVOI-638 ] Changes for publish step to add env and app in upload path#15

Open
ayush-lr wants to merge 9 commits intomasterfrom
feature-publish-custom-path
Open

[ DEVOI-638 ] Changes for publish step to add env and app in upload path#15
ayush-lr wants to merge 9 commits intomasterfrom
feature-publish-custom-path

Conversation

@ayush-lr
Copy link
Copy Markdown
Contributor

@ayush-lr ayush-lr commented Sep 16, 2022

Context

In parallel pubishing support, when running command

 Uploading build/kubernetes/master/build/28077/<env>/<app_name>/manifests_local-staging_stable.yaml to gs://com-eng-ops-hub-services-spinnaker-pipeline/kubernetes/project/LiveRamp/<repo_name>/master/build/28077/artifact/manifests_local-staging_stable.yaml

Even if we made the path build/kubernetes/master/build/28077/<env>/<app_name>/manifests_local-staging_stable.yaml unique, the GCS path is not unique:

gs://com-eng-ops-hub-services-spinnaker-pipeline/kubernetes/project/LiveRamp/<repo_name>/master/build/28077/artifact/manifests_local-staging_stable.yaml

So, while one manifest got published right now, another step could use/move the manifest of another app another gstuil mv or cp cmd execution.

Description

Ticket: https://liveramp.atlassian.net/browse/DEVOI-638

Work Done

So, added a new publish method with optional seperate cmd line options calling a new upload method internally.

@ayush-lr ayush-lr marked this pull request as ready for review September 17, 2022 06:25
@ayush-lr ayush-lr requested a review from a team as a code owner September 17, 2022 06:25
@ranesagar
Copy link
Copy Markdown

Hey @ayush-lr - The env arg is already supported in KDT so I am not sure if it is needed. Let's schedule some time later this week to go over the changes.

@ayush-lr
Copy link
Copy Markdown
Contributor Author

Will book a slot in your calendar

@ayush-lr
Copy link
Copy Markdown
Contributor Author

ayush-lr commented Nov 2, 2022

The word env is just an example of command line parameter. Will not clash with any usage of env as a keyword.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants