Split GamePhotoSubjects into their own DB table#1046
Merged
Toastbrot236 merged 11 commits intoLittleBigRefresh:mainfrom Mar 10, 2026
Merged
Split GamePhotoSubjects into their own DB table#1046Toastbrot236 merged 11 commits intoLittleBigRefresh:mainfrom
Toastbrot236 merged 11 commits intoLittleBigRefresh:mainfrom
Conversation
Contributor
Author
|
The latest commit removes that extra DB call per serialized photo, so now photo fetching is as fast as previously, while still keeping subjects in their own table internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes working on photos easier and less chaotic at the cost of one more DB call per requested photo. This is not that bad, because I do already have something in mind (and partially implemented) which will mostly avoid that and other DB calls when requesting photos, but I have decided to PR that separately, so this PR is more of a preparation for photo optimization.