fix: logo rendering on exported images when user is zoomed in #7008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a logo rendering issue in exported images when users have their browser zoomed in. The fix adjusts the scaling factor used during image capture to account for the device pixel ratio.
Changes:
- Updated the
html2canvasscale parameter to usewindow.devicePixelRatioinstead of a hardcoded value of 1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Back to drawing board, the setting messes up the rendering in other parts: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix logo rendering for exported images when user is zoomed in browser
How did you test this change?
Dev tools
Credit to Slothyman for this fix:
https://discord.com/channels/93055209017729024/372075546231832576/1465710634804183155
Before:
After:
