Skip to content

refactor(eml): clean up eml list implementation #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ElectricalBoy wants to merge 16 commits into
base: main
Choose a base branch
from
Open

refactor(eml): clean up eml list implementation #6999

ElectricalBoy wants to merge 16 commits into from

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Jan 26, 2026 •
edited
Loading

Summary

This PR:

  • rewrites LPDB condition building in Module:ExternalMediaList with condition nodes
  • extracts external media list display to a separate widget

How did you test this change?

preview with dev

@ElectricalBoy ElectricalBoy marked this pull request as ready for review January 26, 2026 04:45
hjpalpha
hjpalpha reviewed Jan 26, 2026
View reviewed changes
ElectricalBoy and others added 2 commits January 26, 2026 14:36
@ElectricalBoy @hjpalpha
update comment
19d786a 
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
@ElectricalBoy
curry
54696fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjpalpha hjpalpha hjpalpha approved these changes

@mbergen mbergen Awaiting requested review from mbergen

@Eetwalt Eetwalt Awaiting requested review from Eetwalt

Assignees

No one assigned

Labels

c: external_media_links

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ElectricalBoy @hjpalpha