Skip to content

refactor(infobox): use super in smash league infobox #6991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ElectricalBoy wants to merge 2 commits into
base: baseclass-super
Choose a base branch
from
Draft

refactor(infobox): use super in smash league infobox #6991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7295ce
use super
ElectricalBoy Jan 22, 2026
aabb4c2
type annotation
ElectricalBoy Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/wikis/commons/Infobox/Basic.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ local Table = Lua.import('Module:Table')
local Info = Lua.import('Module:Info')
local Infobox = Lua.import('Module:Widget/Infobox/Core')

---@class BasicInfobox
---@class BasicInfobox: BaseClass
---@operator call(Frame): BasicInfobox
---@field args table
---@field pagename string
Expand Down
13 changes: 9 additions & 4 deletions lua/wikis/smash/Infobox/League/Custom.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,18 @@ local DEFAULT_TYPE = 'offline'
local MANUAL_SERIES_ICON = 1
local UNKNOWN_DATE_PART = '??'

--- @class SmashLeagueInfobox: InfoboxLeague
--- @field _base InfoboxLeague
---@class SmashLeagueInfobox: InfoboxLeague
---@operator call(Frame): SmashLeagueInfobox
---@field super fun(self: SmashLeagueInfobox): InfoboxLeague
local CustomLeague = Class.new(League)

---@class SmashLeagueInfoboxWidgetInjector: WidgetInjector
---@operator call(SmashLeagueInfobox): SmashLeagueInfoboxWidgetInjector
---@field caller SmashLeagueInfobox
local CustomInjector = Class.new(Injector)

--- @param frame Frame
--- @return Html
--- @return Widget
function CustomLeague.run(frame)
local league = CustomLeague(frame)
league:setWidgetInjector(CustomInjector(league))
Expand Down Expand Up @@ -125,7 +130,7 @@ function CustomLeague:createLiquipediaTierDisplay(args)
return nil
end

return self._base.createLiquipediaTierDisplay(self, args)
return self:super():createLiquipediaTierDisplay(args)
end

--- @param args table
Expand Down
Loading