Skip to content

refactor(match2): use StandardTournamentPartial in match page rendering #6967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElectricalBoy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(match2): use StandardTournamentPartial in match page rendering #6967

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bf96a3
replace MGI with StandardTournament
ElectricalBoy Jan 13, 2026
dcf74d9
cleanup
ElectricalBoy Jan 13, 2026
9b17dc5
memoize getMatchContext
ElectricalBoy Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions lua/wikis/commons/MatchPage/Base.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,16 @@ local CharacterIcon = Lua.import('Module:CharacterIcon')
local Class = Lua.import('Module:Class')
local Countdown = Lua.import('Module:Countdown')
local DateExt = Lua.import('Module:Date/Ext')
local FnUtil = Lua.import('Module:FnUtil')
local Logic = Lua.import('Module:Logic')
local Links = Lua.import('Module:Links')
local Operator = Lua.import('Module:Operator')
local String = Lua.import('Module:StringUtils')
local Table = Lua.import('Module:Table')
local TeamTemplate = Lua.import('Module:TeamTemplate')
local Tournament = Lua.import('Module:Tournament')

local HighlightConditions = Lua.import('Module:HighlightConditions')
local MatchGroupInputUtil = Lua.import('Module:MatchGroup/Input/Util')
local MatchGroupUtil = Lua.import('Module:MatchGroup/Util/Custom')
local DisplayHelper = Lua.import('Module:MatchGroup/Display/Helper')

Expand Down Expand Up @@ -239,7 +240,7 @@ end
function BaseMatchPage:makeDisplayTitle()
local team1data = (self.opponents[1] or {}).teamTemplateData
local team2data = (self.opponents[2] or {}).teamTemplateData
local tournamentName = self.matchData.tickername
local tournamentName = self:getMatchContext().displayName

if Logic.isEmpty(team1data) and Logic.isEmpty(team2data) then
return String.isNotEmpty(tournamentName) and 'Match in ' .. tournamentName or ''
Expand Down Expand Up @@ -346,17 +347,18 @@ function BaseMatchPage:renderGame(game)
end

---@protected
---@return table
function BaseMatchPage:getMatchContext()
return MatchGroupInputUtil.getTournamentContext(self.matchData)
end
---@param self BaseMatchPage
---@return StandardTournamentPartial
BaseMatchPage.getMatchContext = FnUtil.memoize(function (self)
return Tournament.partialTournamentFromMatch(self.matchData)
end)

---@protected
---@return Widget
function BaseMatchPage:getTournamentIcon()
return IconImage{
imageLight = self:getMatchContext().icon,
imageDark = self:getMatchContext().icondark,
imageDark = self:getMatchContext().iconDark,
size = '50x32px',
}
end
Expand Down
Loading