Skip to content

fix: missing nil check in rocketleague ratings #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
umr-1000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: missing nil check in rocketleague ratings #6959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lua/wikis/rocketleague/Ratings/Display/List.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ function RatingsDisplayList.build(teamRankings)
:allDone()

Array.forEach(teams, function(team, rank)
if (team.streak == nil) or (team.rating == nil) then
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parentheses around the nil checks are unnecessary in Lua. The condition can be simplified to: if team.streak == nil or team.rating == nil then

Copilot uses AI. Check for mistakes.
return
end
Comment on lines +36 to +38
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping teams with nil streak or rating values will cause the rank numbers to be incorrect. The rank is passed from Array.forEach which counts all teams including skipped ones. Consider filtering teams before the forEach loop to maintain accurate rankings, or adjust the rank counter when teams are skipped.

Copilot uses AI. Check for mistakes.
Copy link

@truongdongnguyen600-hue truongdongnguyen600-hue Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nếu


local chart = mw.ext.Charts.chart({
xAxis = {
type = 'category',
Expand Down
Loading