Open
Conversation
As opposed to `vim.api.nvim_set_keymap`, it accepts Lua functions as RHS.
Since `remap = false` is the default value of `vim.keymap.set`.
`vim.keymap.set` accepts boolean values for the `buffer` option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Vim's table functions and
vim.keymap.setinstead ofnvim_set_keymap; the latter was introduced with Neovim v0.7. IMO,vim.keymap.setis more flexible as it allows lua functions as RHS and disables remap by default, so that the refactored code is less complex.One may extend this change to adapt the API of
vim.keymap.set:mode="_"specially.bufferoption to theoptionstable.These changes would -- of course -- not be backwards compatible, but would be consistent with
vim.keymap.setand reduce code complexity.What do you think?