Skip to content

fix: missing LinxISA target linkage dependency of Passes#20

Open
FlyMan2004 wants to merge 1 commit into
LinxISA:mainfrom
FlyMan2004:FlyMan2004-patch-fix-linxisa-target-deps
Open

fix: missing LinxISA target linkage dependency of Passes#20
FlyMan2004 wants to merge 1 commit into
LinxISA:mainfrom
FlyMan2004:FlyMan2004-patch-fix-linxisa-target-deps

Conversation

@FlyMan2004
Copy link
Copy Markdown

When lld is used on linux, it complains that symbols defined in lib/Passes/OptimizationLevel.cpp are not found. This commit adds the missing dependency back.

When `lld` is used on linux, it complains that symbols defined in `lib/Passes/OptimizationLevel.cpp` are not found.
This commit adds the missing dependency back.
Copilot AI review requested due to automatic review settings May 16, 2026 18:34
@github-actions
Copy link
Copy Markdown

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CMakeLists.txt for the LinxISA target by adding the Passes component to the LinxISACodeGen target. I have no feedback to provide as there are no review comments.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the LinxISA target’s LLVM component linkage by adding the missing Passes dependency needed by code using llvm/Passes APIs.

Changes:

  • Adds Passes to LinxISACodeGen LINK_COMPONENTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants