Skip to content

Conversation

@Sigma1912
Copy link
Contributor

  • Restores the tooltips for [Delete, Add, Reload, Save] buttons
  • Restores blocking the user from deleting the loaded tool
  • Makes tooledit widget return a list rather than 'None' when multiple checkboxes are selected (required to check if loaded tool is among multiple selected tools)
  • Hides current tool number display in the tooledit frame when the touch keyboard is not active

@Sigma1912 Sigma1912 force-pushed the Gmoccapy-tooltable_Restore_button_tooltips branch from 7f22530 to 57da7f7 Compare January 18, 2026 12:17
@zz912
Copy link
Contributor

zz912 commented Jan 18, 2026

Should be possible add to this PR functionality from #3474 ?

@Sigma1912
Copy link
Contributor Author

Should be possible add to this PR functionality from #3474 ?

I'll have a look

Comment on lines -2043 to +2052
lbl_tool_text = "Tool loaded: " + str(toolnumber)
lbl_tool_text = ""
# When using touch keyboard we display the current tool in the tooltable frame
if self.widgets.chk_use_kb_on_tooledit.get_active():
lbl_tool_text = "Tool loaded: " + str(toolnumber)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not always display the tool number of the current tool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a request to avoid having redundant information:
#3509 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. I disagree 🙃

@hansu
Copy link
Member

hansu commented Jan 18, 2026

  1. Removing the calls of self.widgets.tooledit1.set_selected_tool(act_tool) improves the behaviour in most cases but for on_reload_clicked() I would like to keep it. So that the tool in the spindle is checked when opening the tool table and on reload.
    What do you think?

  2. The "reload tooltable when the widget is shown" has one disadvantage: when you add a new tool, and go back without saving it, your changes got lost. What is the benefit from reload when showing?

@Sigma1912
Copy link
Contributor Author

I would like to keep it. So that the tool in the spindle is checked when opening the tool table and on reload.
What do you think?

No problem

What is the benefit from reload when showing?

Current behavior is that unsaved changes in the tool table are retained when leaving the tool table screen but the changed values are discarded when a tool change is executed and the saved offsets are used instead.
IMO this is unexpected behavior. When I open the tool table I expect to see the values that will be applied when a tool is changed.
Maybe the user should be presented with a popup message if there are unsaved changes on leaving the page?

@zz912
Copy link
Contributor

zz912 commented Jan 18, 2026

I think the reolading is good idea. But I did not test it yet.

@hansu
Copy link
Member

hansu commented Jan 18, 2026

I would like to keep it. So that the tool in the spindle is checked when opening the tool table and on reload.
What do you think?

No problem

👍

Maybe the user should be presented with a popup message if there are unsaved changes on leaving the page?

That would be the cleanest solution.
Then we might also save the tool table when doing a tool change. Imagine someone changes the offsets of a tool and then initiates a tool change for that tool. Then the newly entered offsets wouldn't be used.
Or add another warning message like "Tool table contains unsaved changes. They will get lost after the Tool change."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants