Skip to content

[refactor] #190 qa #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lsakee merged 4 commits into from
Nov 24, 2024
Merged

[refactor] #190 qa #191

lsakee merged 4 commits into from
Nov 24, 2024

Conversation

@leeseokchan00
Copy link
Contributor

@leeseokchan00 leeseokchan00 commented Nov 13, 2024

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ์ตœ๊ทผ์ €์žฅํ•œ๋งํฌ ํด๋ฆฝ ์•ˆ๋ณด์ด๋Š”๊ฑฐ
  • ํด๋ฆฝ ์ด๋™ ํ† ์ŠคํŠธ๋ฉ”์„ธ์ง€
  • ํด๋ฆฝ ์ด๋™ ์ „์ฒด ํด๋ฆฝ > ํ˜„์žฌ ํด๋ฆฝ

๐ŸŒฑ PR ํฌ์ธํŠธ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
ํŒŒ์ผ์ฒจ๋ถ€๋ฐ”๋žŒ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

  • Resolved: #์ด์Šˆ๋ฒˆํ˜ธ

@leeseokchan00 leeseokchan00 added ย โ™ป๏ธย [REFACTOR] ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง ์„์ฐฌ ์ด์„์ฐฌ labels Nov 13, 2024
@leeseokchan00 leeseokchan00 self-assigned this Nov 13, 2024
@lsakee lsakee self-requested a review November 24, 2024 11:41
lsakee
lsakee approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsakee lsakee merged commit bc828cb into develop Nov 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsakee lsakee lsakee approved these changes

Assignees

@leeseokchan00 leeseokchan00

Labels

ย โ™ป๏ธย [REFACTOR] ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง ์„์ฐฌ ์ด์„์ฐฌ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leeseokchan00 @lsakee