Implement setPointOfInterest method for iOS#29
Open
san-smith wants to merge 2 commits intoLightsnap:masterfrom
Open
Implement setPointOfInterest method for iOS#29san-smith wants to merge 2 commits intoLightsnap:masterfrom
san-smith wants to merge 2 commits intoLightsnap:masterfrom
Conversation
Collaborator
|
Looks good, but I think it would be wise to implement it in Android as-well, before we merge |
Author
|
But it works on Android, doesn't it? I found this method didn't work on iOS (I had got the exception |
Collaborator
|
Yeh but there were some issues with the implementation, autofocus was not working after using the focus point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I have implemented the setPointOfInterest method for iOS and modified the example to demonstrate this change.