Rename the plugin to remain compatible with other libraries which use the official Camera plugin.#21
Open
richardbushnell wants to merge 7 commits intoLightsnap:masterfrom
Open
Rename the plugin to remain compatible with other libraries which use the official Camera plugin.#21richardbushnell wants to merge 7 commits intoLightsnap:masterfrom
richardbushnell wants to merge 7 commits intoLightsnap:masterfrom
Conversation
Use name "camera".
gummie4444
requested changes
Sep 7, 2020
Collaborator
gummie4444
left a comment
gummie4444
left a comment
There was a problem hiding this comment.
This makes sense todo, but should be a generic package not com.tudutu
|
Hi any idea on when will this issue be resolved? |
Author
|
Happy to do it, but what would you like me to change it to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use this plugin with our projects, they failed to build because the name of the plugin was the same as the original camera plugin and other plugins were referencing that. To avoid duplication of included plugins, I had to rename the plugin to match the project's name and thought maybe someone else would like to do the same.
Great plugin btw! Thanks for all your great work.