Skip to content

Make the default SLURM requeue signal configurable #21405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martenlienen wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Make the default SLURM requeue signal configurable #21405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/lightning/fabric/plugins/environments/slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,13 @@ class SLURMEnvironment(ClusterEnvironment):

"""

DEFAULT_REQUEUE_SIGNAL = signal.SIGUSR1 if not _IS_WINDOWS else None

def __init__(self, auto_requeue: bool = True, requeue_signal: Optional[signal.Signals] = None) -> None:
super().__init__()
self.auto_requeue = auto_requeue
if requeue_signal is None and not _IS_WINDOWS:
requeue_signal = signal.SIGUSR1
if requeue_signal is None:
requeue_signal = self.DEFAULT_REQUEUE_SIGNAL
self.requeue_signal = requeue_signal
self._validate_srun_used()
self._validate_srun_variables()
Expand Down
Loading