Chore/docker setup#1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e8cd384ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| while ! installation_complete; do | ||
| sleep 2 | ||
| done | ||
|
|
||
| finalize_installation |
There was a problem hiding this comment.
Delay removing setup until the install request has finished
In the Docker install flow, this background watcher removes ${OSTICKET_SETUP_DIR} as soon as ost-config.php flips to installed. The same POST to /setup/install.php still needs files under setup/ after that point: after Installer::install() rewrites the config, setup/install.php selects install-done.inc.php and then requires the setup header/body/footer. On slower fresh installs, if the watcher wakes between the config rewrite and those final require() calls, it can delete the directory out from under the active request and turn a successful install into a 500/blank response. Wait for the request to complete or perform this cleanup on the next container start/manual step instead of immediately in the background.
Useful? React with 👍 / 👎.
No description provided.