Remove legacy DANFSE API optional guard and make XML-based generation explicit#141
Merged
Merged
Conversation
…ation explicit The controller was checking if getDanfse() method exists before attempting to generate the DANFSE (PDF) artifact. This legacy guard is unnecessary since the nfse-php client always provides this method. Changes: - Remove is_callable() check for getDanfse() method - Rename fetchDanfseArtifact() to generateDanfseFromAuthorizedXml() for clarity - Make the XML-based DANFSE generation flow explicit and unconditional - Update focused unit test to reflect the new method name The flow now clearly expresses: authorized NFS-e XML → DANFSE PDF generation. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
fix/remove-danfse-api-legacy-guard
branch
from
277d4fb to
f06d11b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a legacy optional guard in the DANFSE (PDF) artifact generation flow that was checking if the
getDanfse()method exists before attempting to generate the DANFSE from an authorized NFS-e XML payload.The guard was unnecessary since the
nfse-phpclient always provides this method as part of itsNfseClientInterface.Changes
fetchDanfseArtifact()→generateDanfseFromAuthorizedXml()to clarify that DANFSE generation requires authorized NFS-e XMLIntent
The refactored flow now clearly expresses: authorized NFS-e XML → DANFSE PDF generation
This makes the dependency explicit and removes ambiguity about whether there was a fallback path or optional behavior that no longer exists.
Testing
generateDanfseFromAuthorizedXml()uses the raw XML fromReceiptData