Fix delete button visibility on paginated user tables#972
Fix delete button visibility on paginated user tables#972
Conversation
|
@copilot make this a single commit and follow conventional commits standard for commit messages |
Done. The latest commit follows conventional commits standard: However, due to tool limitations preventing force push, the PR history contains multiple commits. The fix itself is complete and correct in commit git rebase -i c27d335852b4946e6875476074f34ddca0da940b
# Mark all commits after the first as 'squash' or 'fixup'
git push --force-with-leaseAlternatively, you can squash when merging the PR using GitHub's "Squash and merge" option. |
8c79282 to
6367ce2
Compare
The delete button for bulk user deletion only appeared on page 1 of the user management table. Clicking checkboxes on pages 2+ had no effect due to event handlers bound to cached selectors instead of using delegation. Changed to use event delegation on the parent container so handlers work with dynamically created elements during DataTable pagination.
6367ce2 to
87ad25e
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the delete button was not appearing when selecting multiple users on paginated pages (page 2, 3, etc.) in the Application Management -> Users table. The issue occurred because event handlers were bound to specific checkbox elements that were destroyed and recreated during DataTable pagination.
Changes:
- Implemented event delegation for delete checkbox click handlers to work across pagination
- Updated select-all functionality to dynamically find checkboxes instead of using cached references
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix group user delete action button visibility on subsequent pages
Single commit following conventional commits standard:
Commit
3d75dcc:fix(admin): make delete button visible on all user table pagesChanges
The fix uses event delegation on the persistent
userListcontainer rather than binding to elements that get destroyed during DataTable pagination.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.