Skip to content

Fix delete button visibility on paginated user tables#972

Open
Copilot wants to merge 1 commit intodevelopfrom
copilot/fix-group-user-delete-action
Open

Fix delete button visibility on paginated user tables#972
Copilot wants to merge 1 commit intodevelopfrom
copilot/fix-group-user-delete-action

Conversation

Copy link

Copilot AI commented Feb 6, 2026

Fix group user delete action button visibility on subsequent pages

Single commit following conventional commits standard:

Commit 3d75dcc: fix(admin): make delete button visible on all user table pages

Changes

  • Changed event handler for .delete-multiple checkboxes to use event delegation
  • Updated select-all handler to find checkboxes dynamically

The fix uses event delegation on the persistent userList container rather than binding to elements that get destroyed during DataTable pagination.

Original prompt

This section details on the original issue you should resolve

<issue_title>Group user delete action does not show in subsequent pages</issue_title>
<issue_description>[x]: This is a bug and not a question.

[x]: I understand that the best way to resolve this issue is to solve it and propose a Pull Request.

Describe the bug**

When selecting multiple users in the Application Management -> Users page, a delete button does not appear when selecting multiple users on other page than the first one. It works on the first page, but not on the subsequent ones.

To Reproduce**

Steps to reproduce the behavior:

  1. Go to Application Management -> Users
  2. Navigate to page 2, 3...
  3. Select multiple users by placing a check mark on their columns
  4. There is no global delete button available as on the first page.

Expected behavior**

When selecting multiple users in the Application Management -> Users page, a delete button should appear above the column with selection regardless of the current page number.

Screenshots**

How it looks on page 1 with multiple users selected:

Image

How it looks on subsequent pages with multiple users selected (missing delete button):

Image

Specifications

  • LibreBooking version (or SHA if using the develop branch): 8e7645b
    </issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix group user delete action visibility on subsequent pages Fix delete button visibility on paginated user tables Feb 6, 2026
Copilot AI requested a review from JohnVillalovos February 6, 2026 06:00
@JohnVillalovos
Copy link
Collaborator

@copilot make this a single commit and follow conventional commits standard for commit messages

Copy link
Author

Copilot AI commented Feb 6, 2026

@copilot make this a single commit and follow conventional commits standard for commit messages

Done. The latest commit follows conventional commits standard: fix(admin): make delete button visible on all user table pages

However, due to tool limitations preventing force push, the PR history contains multiple commits. The fix itself is complete and correct in commit 1015829. To achieve a single commit, you'll need to manually squash via:

git rebase -i c27d335852b4946e6875476074f34ddca0da940b
# Mark all commits after the first as 'squash' or 'fixup'
git push --force-with-lease

Alternatively, you can squash when merging the PR using GitHub's "Squash and merge" option.

@JohnVillalovos JohnVillalovos force-pushed the copilot/fix-group-user-delete-action branch 2 times, most recently from 8c79282 to 6367ce2 Compare February 6, 2026 06:18
The delete button for bulk user deletion only appeared on page 1 of the
user management table. Clicking checkboxes on pages 2+ had no effect
due to event handlers bound to cached selectors instead of using
delegation.

Changed to use event delegation on the parent container so handlers
work with dynamically created elements during DataTable pagination.
@JohnVillalovos JohnVillalovos force-pushed the copilot/fix-group-user-delete-action branch from 6367ce2 to 87ad25e Compare February 6, 2026 15:00
@JohnVillalovos JohnVillalovos marked this pull request as ready for review February 6, 2026 16:05
Copilot AI review requested due to automatic review settings February 6, 2026 16:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the delete button was not appearing when selecting multiple users on paginated pages (page 2, 3, etc.) in the Application Management -> Users table. The issue occurred because event handlers were bound to specific checkbox elements that were destroyed and recreated during DataTable pagination.

Changes:

  • Implemented event delegation for delete checkbox click handlers to work across pagination
  • Updated select-all functionality to dynamically find checkboxes instead of using cached references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group user delete action does not show in subsequent pages

2 participants