Phase 4.B: Proposal Status And Committee Review Backend Integration#1439
Draft
dnlbui wants to merge 3 commits into
Draft
Conversation
9 tasks
* Added a new section for finalizing review results in the Proposal Info Modal, including a button for submission. * Implemented logic to manage review capabilities, allowing committee members to finalize results based on their voting status. * Updated the HTML structure to accommodate the new review result actions and improved styling for better visual clarity. * Refactored related functions to streamline the proposal review process and enhance user experience. These changes significantly improve the functionality of the Proposal Info Modal, facilitating more effective committee decision-making and result finalization.
dnlbui
force-pushed
the
issue-1420-proposal-status-committee-review-ui
branch
from
579a7d2 to
7d3eba2
Compare
dnlbui
force-pushed
the
issue-1421-committee-review-backend-integration
branch
from
94a0f81 to
bece0c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR wires the Phase 4.B committee review UI to real DAO transaction and capability flows.
ProposalInfoModalnow uses proposal capability fields or committee snapshot fallback to show committee-only review actions and the separate review-result finalize action.daoRepobuilds and submitsdao_committee_voteanddao_committee_resulttransactions through the existing signing/injection path.Fixed Flow
Why
Phase 4.A established the review/status UI with local behavior. This change moves the source of truth to backend proposal data and real DAO transactions while keeping transaction construction and submission behind
dao.repo.js.Validation
node --check app.jsnode --check dao.repo.jsCloses #1421
Parent: #1413