Confirm proposal transaction integration#1437
Draft
dnlbui wants to merge 11 commits into
Draft
Conversation
* Added submission handling for proposals, including loading states and error management. * Implemented a new method for refreshing submitted proposals to ensure up-to-date information. * Updated UI elements to reflect the submission process, improving user feedback during proposal signing. This update significantly improves the proposal submission experience by providing clear feedback and handling various states effectively.
* Added a new input field for grace period with a placeholder to indicate default usage. * Implemented logic to display the default grace period hint based on network settings. * Refactored proposal creation draft to include default grace period handling and validation. * Updated UI elements to improve user feedback regarding grace period settings. This update improves the Add Proposal Modal by providing clearer guidance on grace period options and enhancing the overall user experience.
* Updated grace period input field to accept decimal values and changed placeholder text for better user guidance. * Enhanced validation logic for grace period input to ensure non-negative numbers are accepted. * Refactored proposal creation draft to streamline grace period handling and removed reliance on default values. * Improved UI responsiveness for the grace period section in the modal. This update enhances the user experience by providing clearer input expectations and more robust validation for the grace period settings.
* Changed grace period input field to accept milliseconds instead of days, updating associated labels and placeholders for clarity. * Enhanced validation to ensure grace period values are non-negative whole numbers. * Refactored related functions to align with the new milliseconds input format, improving overall consistency in proposal handling. This update improves user guidance and validation for the grace period settings, ensuring a more intuitive experience in the Add Proposal Modal.
…sections of the Add Proposal Modal for improved clarity and functionality. This change enhances user experience by clearly distinguishing between options and parameter changes.
…posal Modal * Introduced escapeHtmlAttribute function to safely handle HTML attributes. * Updated input fields in the Add Proposal Modal to use escapeHtmlAttribute for improved security. * Enhanced styles for buttons in the modal for better visual feedback and user interaction. This update improves the security of user inputs and enhances the overall user experience in the Add Proposal Modal.
… proposal review sections.
* Removed the escapeHtmlAttribute function and replaced its usage with a new escapeDaoFormAttribute function for better handling of HTML attributes in the Add Proposal Modal. * Simplified route handling by removing unnecessary functions related to DAO proposal states. * Enhanced input fields to ensure proper HTML escaping, improving security and user experience. This update streamlines the Add Proposal Modal's functionality and enhances the security of user inputs.
dnlbui
force-pushed
the
issue-1419-confirm-proposal-transaction-integration
branch
from
8ac04ce to
2e2e4a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dao_proposal_createtransactions.Why
This connects the Phase 3.B confirmation screen to the real DAO proposal create action while preserving the existing modal/repository boundaries.
Validation
node --check app.jsnode --check dao.repo.jsgit diff --checkCloses #1419
Parent: #1413