Phase 2.B: Add Proposal Form Data Integration#1435
Draft
dnlbui wants to merge 4 commits into
Draft
Conversation
* Added a new input field for proposal fee in the modal, displaying dynamic values based on emergency status. * Introduced functions to load and refresh the proposal fee, ensuring accurate display and validation. * Enhanced proposal creation draft logic to include proposal fee validation and handling. * Updated the DAO repository with new utility functions for normalizing proposal options and changes. This update improves the functionality and user experience of the DAO proposal modal by providing clear fee information and validation.
* Removed duplicate proposal fee input field from the form. * Ensured the proposal fee field is consistently displayed and integrated within the modal layout. This update streamlines the proposal fee handling in the DAO proposal modal, enhancing clarity and user experience.
* Added alignment for grid items in the proposal modal to start, improving layout consistency. This change enhances the visual structure of the DAO proposal modal, contributing to a better user experience.
* Included a comment to indicate the need for a title field in the DAO proposal draft when supported by the DaoProposalCreate function. This change serves as a reminder for future enhancements to the proposal creation process, ensuring completeness of the draft information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR connects the DAO Add Proposal form to live DAO data sources and builds the draft payload used by the next confirmation phase.
daoReponow loads proposal list data from DAO backend query endpoints and removes the production dependency on generated mock proposals.AddProposalModalloads current DAO parameter values from the network account or/netconfig, loads the proposal fee as read-only DAO data, and validates option/change form state.buildDaoProposalCreateDraftmaps the validated form state into adao_proposal_createdraft while leaving generated-at-submit fields out of the form.Why
Phase 2.B needs the Add Proposal flow to stop relying on mock/local-only form data and produce the transaction draft that Phase 3 can review before signing.
Validation
node --check app.jsnode --check dao.repo.jsgit diff 112c8234d232a546a342e501f62acdaf82493a54 --checkCloses #1417
Parent: #1413