Update DAO modal list UI#1429
Draft
dnlbui wants to merge 5 commits into
Draft
Conversation
* Introduced functions to add UI stress fixtures for DAO proposals, improving testing capabilities. * Enhanced rendering logic for DAO proposal previews, including vote counts and state labels. * Updated the DAO modal to support new UI elements and improved accessibility attributes. * Refactored CSS for better layout and responsiveness in the DAO modal. This update aims to improve the user experience and facilitate better testing of DAO proposal states and interactions.
Collaborator
Author
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6107749f16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* Removed unused functions related to DAO display and voting logic to streamline the codebase. * Updated CSS for DAO modal rows, improving layout and responsiveness. * Enhanced compartment rendering by adjusting padding and alignment for better visual consistency. This update aims to simplify the code and improve the user interface of the DAO modal.
* Renamed and refactored the timestamp formatting function for clarity and improved output. * Removed unused compartment rendering functions to streamline the code. * Updated CSS for DAO modal rows, enhancing layout, alignment, and overall visual consistency. This update aims to simplify the code and improve the user interface of the DAO modal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This PR updates the DAO entry modal into a proposal-list-first UI for Phase 1.A.
DaoModalkeeps the existing modal shell while adding the Active/Archived segmented control, status filter counts, independently scrolling proposal list, and anchored floating add button behavior.dao.repo.jsanddao.mock-data.jsadapt local proposal data to the status/type shape needed to exercise the list UI before backend integration.Placeholders And Follow-Up
This is intentionally still a UI/class-structure step. Route-specific vote/review/result/reward screens remain placeholders or existing detail behavior for now, and the local/mock DAO data is kept only to prove list rendering, filters, and row previews.
Later DAO issues will replace this mock data and wire the real backend/query/action paths, especially Phase 1.B and the later review, voting, results, rewards, and ready-action issues.
Why
Issue #1414 scopes the first DAO pass to the modal/list experience before real DAO backend integration. This keeps the first PR reviewable while preserving hooks for the later route and transaction phases tracked by the parent epic.
Validation
node --check app.jsnode --check dao.repo.jsnode --check dao.mock-data.jsgit diff --check main...HEADCloses #1414
Parent: #1413