Fix helpdesk ticket schema drift#11
Open
panDing19 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some helpdesk fixtures use customer-shaped ticket fields such as
customer_idandcustomer_phone, while the list endpoint assumed every ticket hasreporteranddepartment. This can make tasks using customer-shaped helpdesk fixtures fail or lose key ticket context.Affected tasks
TGUI08_sms_complaint_helpdesk_mattermostFix
customer_id,customer_phone, andcategorywhen present.departmentfrom organization/customer fields when the explicit field is absent.Tests
PYTHONPATH=. uv run pytest tests/test_service_schema_drift.py::test_helpdesk_ticket_list_accepts_customer_shaped_fixture -q