fix: install custom crypto engine before pkijs parseInternalValues#44
Merged
fix: install custom crypto engine before pkijs parseInternalValues#44
Conversation
When a P12 file uses legacy encryption (3DES, RC2) for its safe contents, pkijs needs our custom CryptoEngine during parseInternalValues(). Previously, the engine was only installed lazily on first getCrypto() call in extractPrivateKey(), which runs after parseInternalValues(). This caused 'Unknown contentEncryptionAlgorithm: 1.2.840.113549.1.12.1.3' when a legacy P12 was the first one opened in a process. Our tests masked this because AES tests always ran first, installing the engine as a side effect.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Benchmark ResultsComparisonLoad PDF
Create blank PDF
Add 10 pages
Draw 50 rectangles
Load and save PDF
Load, modify, and save PDF
Extract single page from 100-page PDF
Split 100-page PDF into single-page PDFs
Split 2000-page PDF into single-page PDFs (0.9MB)
Copy 10 pages between documents
Merge 2 x 100-page PDFs
CopyingCopy pages between documents
Duplicate pages within same document
Merge PDFs
Drawingbenchmarks/drawing.bench.ts
Formsbenchmarks/forms.bench.ts
Loadingbenchmarks/loading.bench.ts
Savingbenchmarks/saving.bench.ts
SplittingExtract single page
Split into single-page PDFs
Batch page extraction
Environment
Results are machine-dependent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a P12 file uses legacy encryption (3DES, RC2) for its safe contents,
pkijs needs our custom CryptoEngine during parseInternalValues(). Previously,
the engine was only installed lazily on first getCrypto() call in
extractPrivateKey(), which runs after parseInternalValues().
This caused 'Unknown contentEncryptionAlgorithm: 1.2.840.113549.1.12.1.3'
when a legacy P12 was the first one opened in a process. Our tests masked
this because AES tests always ran first, installing the engine as a side
effect.