Conversation
Lexer747
force-pushed
the
dev
branch
3 times, most recently
from
a359901 to
d2d8d5d
Compare
This patch uses the `fieldalignment` tool to save memory across the board. I don't think this will dramatically improve performance but it's "free" memory savings. Most of the hot paths haven't changed because the savings are all related to moving pointers. Including tests this saves 856 bytes. Excluding tests it's still 552 bytes saved. This patch also adds the `fieldalignment` lint to CI so that I actually maintain these savings. Closes #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch uses the
fieldalignmenttool to save memory across the board. I don't think this will dramatically improve performance but it's "free" memory savings. Most of the hot paths haven't changed because the savings are all related to moving pointers.Including tests this saves 856 bytes. Excluding tests it's still 552 bytes saved.
This patch also adds the
fieldalignmentlint to CI so that I actually maintain these savings.Closes #26