chore: remove unused variable in IsolateService by brunobls · Pull Request #69 · LerianStudio/matcher

brunobls · 2026-03-25T02:14:39Z

Pull Request

Description

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Refactoring (no functional changes)
CI/CD changes
Dependencies update

Checklist

I have tested these changes locally
I have updated the documentation accordingly
I have added necessary comments to the code, especially in complex areas
I have ensured that my changes adhere to the project's coding standards
I have checked for any potential security issues
I have ensured that all tests pass
I have confirmed this code is ready for review

Related Issues

Additional Notes

Note: Please target your PR to the develop branch instead of main.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-03-25T02:14:56Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c1f53486-0bbd-42db-bb68-83accb36dbae

📥 Commits

Reviewing files that changed from the base of the PR and between 67e7ca5 and be44151.

📒 Files selected for processing (1)

tests/chaos/toxics.go

💤 Files with no reviewable changes (1)

tests/chaos/toxics.go

Walkthrough

An unused local variable declaration of type *toxiproxy.Proxy was removed from the IsolateService function in the toxics test file. The variable was not referenced anywhere in the function body, so eliminating it removes dead code and has no impact on the function's behavior or output.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: removing an unused variable from IsolateService, which matches the raw summary and changeset.
Description check	✅ Passed	The description follows the required template structure with all major sections present, including Type of Change (Refactoring selected) and a completed checklist, though the Description field is empty.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

lerian-studio · 2026-03-25T02:15:13Z

Consider updating CHANGELOG.md to document this change. If this change doesn't need a changelog entry, add the skip-changelog label.

lerian-studio · 2026-03-25T02:18:29Z

📊 Unit Test Coverage Report: `matcher`

Metric	Value
Overall Coverage	`78.4%` ✅ PASS
Threshold	`70%`

Coverage by Package

Package	Coverage
`github.com/LerianStudio/matcher/cmd/health-probe`	50.0%
`github.com/LerianStudio/matcher/cmd/matcher`	47.0%
`github.com/LerianStudio/matcher/internal/auth`	83.2%
`github.com/LerianStudio/matcher/internal/bootstrap`	72.1%
`github.com/LerianStudio/matcher/internal/configuration/adapters/audit`	94.8%
`github.com/LerianStudio/matcher/internal/configuration/adapters/http/dto`	96.2%
`github.com/LerianStudio/matcher/internal/configuration/adapters/http`	87.8%
`github.com/LerianStudio/matcher/internal/configuration/adapters/postgres/common`	50.0%
`github.com/LerianStudio/matcher/internal/configuration/adapters/postgres/context`	96.5%
`github.com/LerianStudio/matcher/internal/configuration/adapters/postgres/fee_rule`	98.6%
`github.com/LerianStudio/matcher/internal/configuration/adapters/postgres/field_map`	84.4%
`github.com/LerianStudio/matcher/internal/configuration/adapters/postgres/match_rule`	90.5%
`github.com/LerianStudio/matcher/internal/configuration/adapters/postgres/schedule`	77.7%
`github.com/LerianStudio/matcher/internal/configuration/adapters/postgres/source`	93.0%
`github.com/LerianStudio/matcher/internal/configuration/domain/entities`	91.1%
`github.com/LerianStudio/matcher/internal/configuration/domain/repositories/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/configuration/domain/value_objects`	100.0%
`github.com/LerianStudio/matcher/internal/configuration/ports/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/configuration/services/command`	90.7%
`github.com/LerianStudio/matcher/internal/configuration/services/query`	100.0%
`github.com/LerianStudio/matcher/internal/configuration/services/worker`	92.7%
`github.com/LerianStudio/matcher/internal/discovery/adapters/fetcher`	86.8%
`github.com/LerianStudio/matcher/internal/discovery/adapters/http/dto`	67.8%
`github.com/LerianStudio/matcher/internal/discovery/adapters/http`	86.3%
`github.com/LerianStudio/matcher/internal/discovery/adapters/postgres/connection`	89.3%
`github.com/LerianStudio/matcher/internal/discovery/adapters/postgres/extraction`	86.3%
`github.com/LerianStudio/matcher/internal/discovery/adapters/postgres/schema`	87.8%
`github.com/LerianStudio/matcher/internal/discovery/adapters/redis`	85.5%
`github.com/LerianStudio/matcher/internal/discovery/domain/entities`	86.8%
`github.com/LerianStudio/matcher/internal/discovery/domain/value_objects`	100.0%
`github.com/LerianStudio/matcher/internal/discovery/services/command`	65.2%
`github.com/LerianStudio/matcher/internal/discovery/services/query`	92.1%
`github.com/LerianStudio/matcher/internal/discovery/services/syncer`	78.3%
`github.com/LerianStudio/matcher/internal/discovery/services/worker`	68.1%
`github.com/LerianStudio/matcher/internal/exception/adapters/audit`	84.5%
`github.com/LerianStudio/matcher/internal/exception/adapters/http/connectors`	82.7%
`github.com/LerianStudio/matcher/internal/exception/adapters/http/dto`	100.0%
`github.com/LerianStudio/matcher/internal/exception/adapters/http`	90.4%
`github.com/LerianStudio/matcher/internal/exception/adapters/postgres/comment`	81.8%
`github.com/LerianStudio/matcher/internal/exception/adapters/postgres/dispute`	94.0%
`github.com/LerianStudio/matcher/internal/exception/adapters/postgres/exception`	93.2%
`github.com/LerianStudio/matcher/internal/exception/adapters/redis`	66.9%
`github.com/LerianStudio/matcher/internal/exception/adapters/resolution`	91.7%
`github.com/LerianStudio/matcher/internal/exception/adapters`	100.0%
`github.com/LerianStudio/matcher/internal/exception/domain/dispute`	99.1%
`github.com/LerianStudio/matcher/internal/exception/domain/entities`	100.0%
`github.com/LerianStudio/matcher/internal/exception/domain/repositories/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/exception/domain/services`	89.5%
`github.com/LerianStudio/matcher/internal/exception/domain/value_objects`	94.7%
`github.com/LerianStudio/matcher/internal/exception/ports/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/exception/ports`	50.0%
`github.com/LerianStudio/matcher/internal/exception/services/command`	89.0%
`github.com/LerianStudio/matcher/internal/exception/services/query`	99.0%
`github.com/LerianStudio/matcher/internal/governance/adapters/audit`	91.8%
`github.com/LerianStudio/matcher/internal/governance/adapters/http/dto`	100.0%
`github.com/LerianStudio/matcher/internal/governance/adapters/http`	92.3%
`github.com/LerianStudio/matcher/internal/governance/adapters/postgres/actor_mapping`	97.5%
`github.com/LerianStudio/matcher/internal/governance/adapters/postgres/archive_metadata`	83.3%
`github.com/LerianStudio/matcher/internal/governance/adapters/postgres`	95.7%
`github.com/LerianStudio/matcher/internal/governance/domain/entities`	97.6%
`github.com/LerianStudio/matcher/internal/governance/domain/hashchain`	88.5%
`github.com/LerianStudio/matcher/internal/governance/domain/repositories/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/governance/services/command`	91.1%
`github.com/LerianStudio/matcher/internal/governance/services/query`	100.0%
`github.com/LerianStudio/matcher/internal/governance/services/worker`	83.3%
`github.com/LerianStudio/matcher/internal/ingestion/adapters/http/dto`	80.0%
`github.com/LerianStudio/matcher/internal/ingestion/adapters/http`	94.2%
`github.com/LerianStudio/matcher/internal/ingestion/adapters/parsers`	95.9%
`github.com/LerianStudio/matcher/internal/ingestion/adapters/postgres/common`	59.5%
`github.com/LerianStudio/matcher/internal/ingestion/adapters/postgres/job`	95.9%
`github.com/LerianStudio/matcher/internal/ingestion/adapters/postgres/transaction`	95.7%
`github.com/LerianStudio/matcher/internal/ingestion/adapters/rabbitmq`	77.7%
`github.com/LerianStudio/matcher/internal/ingestion/adapters/redis`	83.5%
`github.com/LerianStudio/matcher/internal/ingestion/domain/entities`	96.8%
`github.com/LerianStudio/matcher/internal/ingestion/domain/repositories/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/ingestion/domain/value_objects`	97.1%
`github.com/LerianStudio/matcher/internal/ingestion/services/command`	85.9%
`github.com/LerianStudio/matcher/internal/ingestion/services/query`	86.7%
`github.com/LerianStudio/matcher/internal/matching/adapters/http/dto`	95.0%
`github.com/LerianStudio/matcher/internal/matching/adapters/http`	91.9%
`github.com/LerianStudio/matcher/internal/matching/adapters/postgres/adjustment`	95.1%
`github.com/LerianStudio/matcher/internal/matching/adapters/postgres/exception_creator`	95.8%
`github.com/LerianStudio/matcher/internal/matching/adapters/postgres/fee_schedule`	92.2%
`github.com/LerianStudio/matcher/internal/matching/adapters/postgres/fee_variance`	96.8%
`github.com/LerianStudio/matcher/internal/matching/adapters/postgres/match_group`	90.8%
`github.com/LerianStudio/matcher/internal/matching/adapters/postgres/match_item`	96.2%
`github.com/LerianStudio/matcher/internal/matching/adapters/postgres/match_run`	96.5%
`github.com/LerianStudio/matcher/internal/matching/adapters/postgres/rate`	99.2%
`github.com/LerianStudio/matcher/internal/matching/adapters/rabbitmq`	72.8%
`github.com/LerianStudio/matcher/internal/matching/adapters/redis`	92.8%
`github.com/LerianStudio/matcher/internal/matching/domain/entities`	98.6%
`github.com/LerianStudio/matcher/internal/matching/domain/enums`	100.0%
`github.com/LerianStudio/matcher/internal/matching/domain/repositories/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/matching/domain/services`	88.0%
`github.com/LerianStudio/matcher/internal/matching/domain/value_objects`	100.0%
`github.com/LerianStudio/matcher/internal/matching/ports/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/matching/services/command`	86.7%
`github.com/LerianStudio/matcher/internal/matching/services/query`	94.1%
`github.com/LerianStudio/matcher/internal/outbox/adapters/postgres`	100.0%
`github.com/LerianStudio/matcher/internal/outbox/domain/entities`	100.0%
`github.com/LerianStudio/matcher/internal/outbox/domain/repositories/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/outbox/services`	84.5%
`github.com/LerianStudio/matcher/internal/reporting/adapters/http/dto`	82.2%
`github.com/LerianStudio/matcher/internal/reporting/adapters/http`	91.5%
`github.com/LerianStudio/matcher/internal/reporting/adapters/postgres/dashboard`	92.3%
`github.com/LerianStudio/matcher/internal/reporting/adapters/postgres/export_job`	94.5%
`github.com/LerianStudio/matcher/internal/reporting/adapters/postgres/report`	88.4%
`github.com/LerianStudio/matcher/internal/reporting/adapters/redis`	89.9%
`github.com/LerianStudio/matcher/internal/reporting/adapters/storage`	86.4%
`github.com/LerianStudio/matcher/internal/reporting/domain/entities`	97.7%
`github.com/LerianStudio/matcher/internal/reporting/domain/repositories/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/reporting/ports/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/reporting/services/command`	98.6%
`github.com/LerianStudio/matcher/internal/reporting/services/query/exports`	83.0%
`github.com/LerianStudio/matcher/internal/reporting/services/query`	87.4%
`github.com/LerianStudio/matcher/internal/reporting/services/worker`	86.8%
`github.com/LerianStudio/matcher/internal/shared/adapters/cross`	92.6%
`github.com/LerianStudio/matcher/internal/shared/adapters/http`	86.2%
`github.com/LerianStudio/matcher/internal/shared/adapters/postgres/common`	93.7%
`github.com/LerianStudio/matcher/internal/shared/adapters/postgres/outbox`	76.7%
`github.com/LerianStudio/matcher/internal/shared/adapters/rabbitmq`	92.0%
`github.com/LerianStudio/matcher/internal/shared/domain/exception`	95.4%
`github.com/LerianStudio/matcher/internal/shared/domain/fee`	93.4%
`github.com/LerianStudio/matcher/internal/shared/domain`	99.3%
`github.com/LerianStudio/matcher/internal/shared/infrastructure/testutil`	41.4%
`github.com/LerianStudio/matcher/internal/shared/ports/mocks`	0.0%
`github.com/LerianStudio/matcher/internal/shared/ports`	29.1%
`github.com/LerianStudio/matcher/internal/shared/sanitize`	96.0%
`github.com/LerianStudio/matcher/internal/shared/testutil`	98.6%
`github.com/LerianStudio/matcher/internal/shared/utils`	100.0%
`github.com/LerianStudio/matcher/internal/testutil`	95.4%
`github.com/LerianStudio/matcher/pkg/chanutil`	100.0%
`github.com/LerianStudio/matcher/pkg/storageopt`	100.0%
`github.com/LerianStudio/matcher/tests/chaos`	84.1%

Generated by Go PR Analysis workflow

chore: remove unused variable in IsolateService

be44151

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions bot added the area: tests label Mar 25, 2026

lerian-studio added the size/XS label Mar 25, 2026

coderabbitai bot approved these changes Mar 25, 2026

View reviewed changes

fredcamaral closed this Mar 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove unused variable in IsolateService#69

chore: remove unused variable in IsolateService#69
brunobls wants to merge 1 commit intodevelopfrom
fix/remove-unused-var-toxics

brunobls commented Mar 25, 2026

Uh oh!

coderabbitai bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

lerian-studio commented Mar 25, 2026

Uh oh!

lerian-studio commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

brunobls commented Mar 25, 2026

Pull Request

Description

Type of Change

Checklist

Related Issues

Additional Notes

Uh oh!

coderabbitai bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

lerian-studio commented Mar 25, 2026

Uh oh!

lerian-studio commented Mar 25, 2026

📊 Unit Test Coverage Report: matcher

Coverage by Package

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 25, 2026 •

edited

Loading

📊 Unit Test Coverage Report: `matcher`